Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update array type when processing staged memory #1751

Merged
merged 1 commit into from
Jun 19, 2023
Merged

fix: Update array type when processing staged memory #1751

merged 1 commit into from
Jun 19, 2023

Conversation

guipublic
Copy link
Contributor

Description

Problem*

Resolves #1706

Summary*

We update the type of the array when applying staged memory operations.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray changed the title fix: Fix issue 1706 - Update array type when processing staged memory fix: Update array type when processing staged memory Jun 19, 2023
@kevaundray kevaundray added this pull request to the merge queue Jun 19, 2023
Merged via the queue into master with commit 27eb748 Jun 19, 2023
@kevaundray kevaundray deleted the gd/issue_1706 branch June 19, 2023 20:12
This was referenced Jun 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assertion `(op.access_type == 0)' failed
2 participants
@guipublic @kevaundray