feat(driver): Remove Driver struct and refactor functions to take Context
#1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
changed the title
Driver struct and refactor functions to take context
TomAFrench
previously approved these changes
Jul 6, 2023
|
Some merge conflicts but gtg after that. |
phated
force-pushed
the
phated/kill-driver
branch
from
196299f
to
9417e80
Compare
TomAFrench
changed the title
Driver struct and refactor functions to take contextDriver struct and refactor functions to take Context
TomAFrench
approved these changes
Jul 6, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Towards #1838
Summary*
This removes the
Driverstruct that takes ownership over aContext. The struct is replaced by functions that take aContextand work with it, which allows for various parts of the system to own aContextthey create, such as theLspStateor nargo CLI.Functions in the driver that were related to retrieving information about the program were moved onto the
Context.Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.