Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather feedback on printing proofs to stdout #2109

Closed
phated opened this issue Aug 1, 2023 · 5 comments
Closed

Gather feedback on printing proofs to stdout #2109

phated opened this issue Aug 1, 2023 · 5 comments
Assignees

Comments

@phated
Copy link
Contributor

phated commented Aug 1, 2023

In #1992, we removed the ability for nargo prove to print a proof on stdout and instead it is always saved to the filesystem.

We are looking for feedback on this change. Do you have any uses cases that would need the proof printed on stdout?

@Savio-Sou
Copy link
Collaborator

cc @critesjosh @signorecello

@critesjosh
Copy link
Contributor

I haven't encountered a need for it to be printed.

@critesjosh
Copy link
Contributor

critesjosh commented Aug 3, 2023

I've heard devs find it confusing that nargo prove x does not print anything when it runs successfully. Maybe printing something like "Proof ran successfully in X ms. Stored at target/x.json." on a successful run would help reduce confusion.

@signorecello
Copy link
Contributor

I agree with @critesjosh we should give some feedback when proving, currently it just hangs and it can be confusing. For example, if it needs to download the backend and my connection is slow, I'm left in the dark on what exactly is happening.

@Savio-Sou can we reopen?

@Savio-Sou
Copy link
Collaborator

Those sound like two new Issues versus this (printing the proof upon proving).

Instead of reopening, @signorecello could you help create two new ones for:

  1. Add successful message for nargo prove and nargo verify
  2. Add downloading message in Nargo for backend and SRS downloads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

6 participants