Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CrateName does not reject empty strings #2287

Closed
critesjosh opened this issue Aug 11, 2023 · 3 comments · Fixed by #2293
Closed

CrateName does not reject empty strings #2287

critesjosh opened this issue Aug 11, 2023 · 3 comments · Fixed by #2293
Assignees
@TomAFrench
Labels
bug Something isn't working

Comments

@critesjosh
Copy link
Contributor

critesjosh commented Aug 11, 2023 •
edited
Loading

Aim

nargo compile shouldn't produce an empty target dir when the artifact (target.json) is placed in the project root.

Expected Behavior

see above.

Bug

no error messages.

To Reproduce

  1. run nargo compile. see output described above

Installation Method

None

Nargo Version

nargo 0.9.0 (git version hash: 3d1b252, is dirty: false)

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@critesjosh critesjosh added the bug Something isn't working label Aug 11, 2023
@TomAFrench
Copy link
Member

Can you give more concrete reproduction steps? This isn't very clear to me.

@critesjosh
Copy link
Contributor Author

Sorry, I left out an important detail. This only happens when name = "" in Nargo.toml.

You can create a new noir project with nargo init. Make the name an empty string. then run nargo compile

@TomAFrench TomAFrench changed the title nargo compile produces target.json and empty ./target dir CrateName does not reject empty strings Aug 11, 2023
@TomAFrench
Copy link
Member

Ok, looks like we're not doing enough validation there.

@TomAFrench TomAFrench self-assigned this Aug 11, 2023
@TomAFrench TomAFrench mentioned this issue Aug 11, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomAFrench TomAFrench

Labels
bug Something isn't working
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Require package names to be non-empty noir-lang/noir
3 participants
@TomAFrench @critesjosh @kevaundray