Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discrepancy in serialization between acvm_js and backends in Noir.js #2771

Closed
kevaundray opened this issue Sep 21, 2023 · 0 comments · Fixed by #3104
Closed

Discrepancy in serialization between acvm_js and backends in Noir.js #2771

kevaundray opened this issue Sep 21, 2023 · 0 comments · Fixed by #3104
Assignees
@TomAFrench
Labels
enhancement New feature or request js Noir's JavaScript packages

Comments

@kevaundray
Copy link
Contributor

Problem

See this PR comment: #2732 (comment)

Happy Case

We should standardize on the API for when to use compressed and uncompressed bytes

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@kevaundray kevaundray added the enhancement New feature or request label Sep 21, 2023
@kevaundray kevaundray mentioned this issue Sep 21, 2023
Merged
5 tasks
@Savio-Sou Savio-Sou added the js Noir's JavaScript packages label Oct 10, 2023
@TomAFrench TomAFrench mentioned this issue Oct 11, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomAFrench TomAFrench

Labels
enhancement New feature or request js Noir's JavaScript packages
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: standardize witness map serialization format in JS noir-lang/noir
3 participants
@TomAFrench @kevaundray @Savio-Sou