Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing noi_wasm test in CI #3033

Closed
kevaundray opened this issue Oct 8, 2023 · 2 comments
Closed

Fix failing noi_wasm test in CI #3033

kevaundray opened this issue Oct 8, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@kevaundray
Copy link
Contributor

Aim

Currently Test noir_wasm is failing the CI -- on master the error is:

https://github.com/noir-lang/noir/actions/runs/6436173480/job/17479101660

Expected Behavior

Tests to pass

Bug

Backend related error, though its strange for two reasons:

  • The backend failure message reason is blank, even though we merged a PR to add this
  • The WASM version should not require the backend -- it should get the information needed by the info command from typescript

To Reproduce

Installation Method

None

Nargo Version

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@kevaundray kevaundray added the bug Something isn't working label Oct 8, 2023
@TomAFrench
Copy link
Member

This seems like an intermittent failure in bb, rerunning that workflow results in no backend error. The error here is the one introduced in #2989

The backend failure message reason is blank, even though we merged a PR to add this

It's likely that bb is just returning nothing on an error. See #2790 (comment)

The WASM version should not require the backend -- it should get the information needed by the info command from typescript

We use the CLI in order to check that we get the same build outputs based on the same commit.

@TomAFrench
Copy link
Member

closed by #3040 and #3039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants