Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate usage of "big add" gates in the bb dsl folder #6085

Open
TomAFrench opened this issue Sep 18, 2024 · 0 comments · May be fixed by #6268
Open

Investigate usage of "big add" gates in the bb dsl folder #6085

TomAFrench opened this issue Sep 18, 2024 · 0 comments · May be fixed by #6268
Assignees
@guipublic

Comments

@TomAFrench
Copy link
Member

Speaking with Kesha today he mentioned that we could accumulate the intermediate variables created when decomposing a large expression more efficiently by using the "big_add" gates in barretenberg.

https://github.com/AztecProtocol/aztec-packages/blob/184cc882b3f1b90d74f149e46100474263a3665d/barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/ultra_circuit_builder.cpp#L265-L297

We should look at having the dsl folder produce these gates and also how to modify how we break up large expressions to ensure that it's compatible.
@guipublic guipublic self-assigned this Sep 20, 2024
@guipublic guipublic mentioned this issue Oct 2, 2024
Merged
guipublic added a commit to AztecProtocol/aztec-packages that referenced this issue Oct 3, 2024
@guipublic
feat: Add support for unlimited width in ACIR (#8960)
3e05e22 
Handle ACIR AssertZero opcodes of any width, by creating intermediate
quad gates using w4_omega.
'fixes' noir-lang/noir#6085, but we still need
to have Noir using the unlimited width.
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this issue Oct 4, 2024
@guipublic @AztecBot
feat: Add support for unlimited width in ACIR (#8960)
f04166e 
Handle ACIR AssertZero opcodes of any width, by creating intermediate
quad gates using w4_omega.
'fixes' noir-lang/noir#6085, but we still need
to have Noir using the unlimited width.
@guipublic guipublic linked a pull request Oct 10, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guipublic guipublic

Labels
None yet
Projects
Noir
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove 'single use' intermediate variables noir-lang/noir
2 participants
@TomAFrench @guipublic