diff --git a/Cargo.lock b/Cargo.lock index cdc1d75a421..4b56812e96d 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2619,6 +2619,7 @@ name = "nargo_fmt" version = "0.34.0" dependencies = [ "bytecount", + "noirc_errors", "noirc_frontend", "serde", "similar-asserts", diff --git a/compiler/noirc_driver/src/abi_gen.rs b/compiler/noirc_driver/src/abi_gen.rs index be89b24fee5..fcae136349d 100644 --- a/compiler/noirc_driver/src/abi_gen.rs +++ b/compiler/noirc_driver/src/abi_gen.rs @@ -9,8 +9,12 @@ use noirc_abi::{ use noirc_frontend::ast::{Signedness, Visibility}; use noirc_frontend::{ hir::Context, - hir_def::{expr::HirArrayLiteral, function::Param, stmt::HirPattern, types::Type}, - macros_api::{HirExpression, HirLiteral}, + hir_def::{ + expr::{HirArrayLiteral, HirExpression, HirLiteral}, + function::Param, + stmt::HirPattern, + types::Type, + }, node_interner::{FuncId, NodeInterner}, }; use noirc_frontend::{TypeBinding, TypeVariableKind}; diff --git a/compiler/noirc_frontend/src/ast/expression.rs b/compiler/noirc_frontend/src/ast/expression.rs index 7b0a6d028de..095356682fd 100644 --- a/compiler/noirc_frontend/src/ast/expression.rs +++ b/compiler/noirc_frontend/src/ast/expression.rs @@ -6,8 +6,9 @@ use crate::ast::{ UnresolvedTraitConstraint, UnresolvedType, UnresolvedTypeData, Visibility, }; use crate::hir::def_collector::errors::DefCollectorErrorKind; -use crate::macros_api::StructId; -use crate::node_interner::{ExprId, InternedExpressionKind, InternedStatementKind, QuotedTypeId}; +use crate::node_interner::{ + ExprId, InternedExpressionKind, InternedStatementKind, QuotedTypeId, StructId, +}; use crate::token::{Attributes, FunctionAttribute, Token, Tokens}; use crate::{Kind, Type}; use acvm::{acir::AcirField, FieldElement}; diff --git a/compiler/noirc_frontend/src/ast/statement.rs b/compiler/noirc_frontend/src/ast/statement.rs index 4abea8cebb4..2d835482082 100644 --- a/compiler/noirc_frontend/src/ast/statement.rs +++ b/compiler/noirc_frontend/src/ast/statement.rs @@ -10,12 +10,14 @@ use super::{ BlockExpression, ConstructorExpression, Expression, ExpressionKind, GenericTypeArgs, IndexExpression, ItemVisibility, MemberAccessExpression, MethodCallExpression, UnresolvedType, }; +use crate::ast::UnresolvedTypeData; use crate::elaborator::types::SELF_TYPE_NAME; use crate::lexer::token::SpannedToken; -use crate::macros_api::{NodeInterner, SecondaryAttribute, UnresolvedTypeData}; -use crate::node_interner::{InternedExpressionKind, InternedPattern, InternedStatementKind}; +use crate::node_interner::{ + InternedExpressionKind, InternedPattern, InternedStatementKind, NodeInterner, +}; use crate::parser::{ParserError, ParserErrorReason}; -use crate::token::Token; +use crate::token::{SecondaryAttribute, Token}; /// This is used when an identifier fails to parse in the parser. /// Instead of failing the parse, we can often recover using this diff --git a/compiler/noirc_frontend/src/ast/traits.rs b/compiler/noirc_frontend/src/ast/traits.rs index 3df9939dc70..d2fa95e4f5a 100644 --- a/compiler/noirc_frontend/src/ast/traits.rs +++ b/compiler/noirc_frontend/src/ast/traits.rs @@ -7,8 +7,8 @@ use crate::ast::{ BlockExpression, Expression, FunctionReturnType, Ident, NoirFunction, Path, UnresolvedGenerics, UnresolvedType, }; -use crate::macros_api::SecondaryAttribute; use crate::node_interner::TraitId; +use crate::token::SecondaryAttribute; use super::{Documented, GenericTypeArgs, ItemVisibility}; diff --git a/compiler/noirc_frontend/src/elaborator/comptime.rs b/compiler/noirc_frontend/src/elaborator/comptime.rs index 560be895628..4d6095724f4 100644 --- a/compiler/noirc_frontend/src/elaborator/comptime.rs +++ b/compiler/noirc_frontend/src/elaborator/comptime.rs @@ -6,7 +6,7 @@ use iter_extended::vecmap; use noirc_errors::{Location, Span}; use crate::{ - ast::Documented, + ast::{Documented, Expression, ExpressionKind}, hir::{ comptime::{Interpreter, InterpreterError, Value}, def_collector::{ @@ -19,13 +19,11 @@ use crate::{ def_map::{LocalModuleId, ModuleId}, resolution::errors::ResolverError, }, - hir_def::expr::HirIdent, + hir_def::expr::{HirExpression, HirIdent}, lexer::Lexer, - macros_api::{ - Expression, ExpressionKind, HirExpression, NodeInterner, SecondaryAttribute, StructId, - }, - node_interner::{DefinitionKind, DependencyId, FuncId, TraitId}, + node_interner::{DefinitionKind, DependencyId, FuncId, NodeInterner, StructId, TraitId}, parser::{self, TopLevelStatement, TopLevelStatementKind}, + token::SecondaryAttribute, Type, TypeBindings, UnificationError, }; diff --git a/compiler/noirc_frontend/src/elaborator/expressions.rs b/compiler/noirc_frontend/src/elaborator/expressions.rs index 46a22bb232f..cbd72788c85 100644 --- a/compiler/noirc_frontend/src/elaborator/expressions.rs +++ b/compiler/noirc_frontend/src/elaborator/expressions.rs @@ -5,8 +5,10 @@ use rustc_hash::FxHashSet as HashSet; use crate::{ ast::{ - ArrayLiteral, ConstructorExpression, IfExpression, InfixExpression, Lambda, UnaryOp, - UnresolvedTypeData, UnresolvedTypeExpression, + ArrayLiteral, BlockExpression, CallExpression, CastExpression, ConstructorExpression, + Expression, ExpressionKind, Ident, IfExpression, IndexExpression, InfixExpression, Lambda, + Literal, MemberAccessExpression, MethodCallExpression, PrefixExpression, StatementKind, + UnaryOp, UnresolvedTypeData, UnresolvedTypeExpression, }, hir::{ comptime::{self, InterpreterError}, @@ -17,16 +19,12 @@ use crate::{ expr::{ HirArrayLiteral, HirBinaryOp, HirBlockExpression, HirCallExpression, HirCastExpression, HirConstructorExpression, HirExpression, HirIfExpression, HirIndexExpression, - HirInfixExpression, HirLambda, HirMemberAccess, HirMethodCallExpression, + HirInfixExpression, HirLambda, HirLiteral, HirMemberAccess, HirMethodCallExpression, HirPrefixExpression, }, + stmt::HirStatement, traits::TraitConstraint, }, - macros_api::{ - BlockExpression, CallExpression, CastExpression, Expression, ExpressionKind, HirLiteral, - HirStatement, Ident, IndexExpression, Literal, MemberAccessExpression, - MethodCallExpression, PrefixExpression, StatementKind, - }, node_interner::{DefinitionKind, ExprId, FuncId, InternedStatementKind, TraitMethodId}, token::Tokens, Kind, QuotedType, Shared, StructType, Type, diff --git a/compiler/noirc_frontend/src/elaborator/lints.rs b/compiler/noirc_frontend/src/elaborator/lints.rs index 8253921d305..c0a18d219b7 100644 --- a/compiler/noirc_frontend/src/elaborator/lints.rs +++ b/compiler/noirc_frontend/src/elaborator/lints.rs @@ -1,14 +1,15 @@ use crate::{ - ast::{FunctionKind, Ident}, + ast::{FunctionKind, Ident, NoirFunction, Signedness, UnaryOp, Visibility}, graph::CrateId, hir::{ resolution::errors::{PubPosition, ResolverError}, type_check::TypeCheckError, }, - hir_def::{expr::HirIdent, function::FuncMeta}, - macros_api::{ - HirExpression, HirLiteral, NodeInterner, NoirFunction, Signedness, UnaryOp, Visibility, + hir_def::{ + expr::{HirExpression, HirIdent, HirLiteral}, + function::FuncMeta, }, + node_interner::NodeInterner, node_interner::{DefinitionKind, ExprId, FuncId, FunctionModifiers}, Type, }; diff --git a/compiler/noirc_frontend/src/elaborator/mod.rs b/compiler/noirc_frontend/src/elaborator/mod.rs index c9195fdc267..5f1b97f5eed 100644 --- a/compiler/noirc_frontend/src/elaborator/mod.rs +++ b/compiler/noirc_frontend/src/elaborator/mod.rs @@ -3,56 +3,42 @@ use std::{ rc::Rc, }; +use crate::ast::ItemVisibility; use crate::{ - ast::{FunctionKind, GenericTypeArgs, UnresolvedTraitConstraint}, + ast::{ + BlockExpression, FunctionKind, GenericTypeArgs, Ident, NoirFunction, NoirStruct, Param, + Path, Pattern, TraitBound, UnresolvedGeneric, UnresolvedGenerics, + UnresolvedTraitConstraint, UnresolvedTypeData, + }, + graph::CrateId, hir::{ def_collector::dc_crate::{ - filter_literal_globals, CompilationError, ImplMap, UnresolvedGlobal, UnresolvedStruct, - UnresolvedTypeAlias, + filter_literal_globals, CompilationError, ImplMap, UnresolvedFunctions, + UnresolvedGlobal, UnresolvedStruct, UnresolvedTraitImpl, UnresolvedTypeAlias, }, - def_map::DefMaps, + def_collector::{dc_crate::CollectedItems, errors::DefCollectorErrorKind}, + def_map::{DefMaps, ModuleData}, + def_map::{LocalModuleId, ModuleDefId, ModuleId, MAIN_FUNCTION}, resolution::errors::ResolverError, + resolution::import::PathResolution, scope::ScopeForest as GenericScopeForest, type_check::{generics::TraitGenerics, TypeCheckError}, + Context, }, + hir_def::traits::TraitImpl, hir_def::{ expr::{HirCapturedVar, HirIdent}, - function::FunctionBody, + function::{FuncMeta, FunctionBody, HirFunction}, traits::TraitConstraint, types::{Generics, Kind, ResolvedGeneric}, }, - macros_api::{ - BlockExpression, Ident, NodeInterner, NoirFunction, NoirStruct, Pattern, - SecondaryAttribute, StructId, - }, node_interner::{ - DefinitionKind, DependencyId, ExprId, FuncId, FunctionModifiers, GlobalId, ReferenceId, - TraitId, TypeAliasId, + DefinitionKind, DependencyId, ExprId, FuncId, FunctionModifiers, GlobalId, NodeInterner, + ReferenceId, StructId, TraitId, TraitImplId, TypeAliasId, }, - token::CustomAttribute, + token::{CustomAttribute, SecondaryAttribute}, Shared, Type, TypeVariable, }; -use crate::{ - ast::{TraitBound, UnresolvedGeneric, UnresolvedGenerics}, - graph::CrateId, - hir::{ - def_collector::{dc_crate::CollectedItems, errors::DefCollectorErrorKind}, - def_map::{LocalModuleId, ModuleDefId, ModuleId, MAIN_FUNCTION}, - resolution::import::PathResolution, - Context, - }, - hir_def::function::{FuncMeta, HirFunction}, - macros_api::{Param, Path, UnresolvedTypeData}, - node_interner::TraitImplId, -}; -use crate::{ - hir::{ - def_collector::dc_crate::{UnresolvedFunctions, UnresolvedTraitImpl}, - def_map::ModuleData, - }, - hir_def::traits::TraitImpl, - macros_api::ItemVisibility, -}; mod comptime; mod expressions; diff --git a/compiler/noirc_frontend/src/elaborator/patterns.rs b/compiler/noirc_frontend/src/elaborator/patterns.rs index 56b7eb30b3b..91c4b17a857 100644 --- a/compiler/noirc_frontend/src/elaborator/patterns.rs +++ b/compiler/noirc_frontend/src/elaborator/patterns.rs @@ -3,17 +3,18 @@ use noirc_errors::{Location, Span}; use rustc_hash::FxHashSet as HashSet; use crate::{ - ast::{TypePath, UnresolvedType, ERROR_IDENT}, + ast::{ + Expression, ExpressionKind, Ident, Path, Pattern, TypePath, UnresolvedType, ERROR_IDENT, + }, hir::{ def_collector::dc_crate::CompilationError, resolution::errors::ResolverError, type_check::{Source, TypeCheckError}, }, hir_def::{ - expr::{HirIdent, HirMethodReference, ImplKind}, + expr::{HirExpression, HirIdent, HirMethodReference, ImplKind}, stmt::HirPattern, }, - macros_api::{Expression, ExpressionKind, HirExpression, Ident, Path, Pattern}, node_interner::{DefinitionId, DefinitionKind, ExprId, FuncId, GlobalId, TraitImplKind}, ResolvedGeneric, Shared, StructType, Type, TypeBindings, }; diff --git a/compiler/noirc_frontend/src/elaborator/scope.rs b/compiler/noirc_frontend/src/elaborator/scope.rs index 8e746256142..0fb5a58035a 100644 --- a/compiler/noirc_frontend/src/elaborator/scope.rs +++ b/compiler/noirc_frontend/src/elaborator/scope.rs @@ -1,11 +1,10 @@ use noirc_errors::{Location, Spanned}; -use crate::ast::{PathKind, ERROR_IDENT}; +use crate::ast::{Ident, Path, PathKind, ERROR_IDENT}; use crate::hir::def_map::{LocalModuleId, ModuleId}; use crate::hir::resolution::import::{PathResolution, PathResolutionResult}; use crate::hir::resolution::path_resolver::{PathResolver, StandardPathResolver}; use crate::hir::scope::{Scope as GenericScope, ScopeTree as GenericScopeTree}; -use crate::macros_api::Ident; use crate::{ hir::{ def_map::{ModuleDefId, TryFromModuleDefId}, @@ -15,8 +14,7 @@ use crate::{ expr::{HirCapturedVar, HirIdent}, traits::Trait, }, - macros_api::{Path, StructId}, - node_interner::{DefinitionId, TraitId}, + node_interner::{DefinitionId, StructId, TraitId}, Shared, StructType, }; use crate::{Type, TypeAlias}; diff --git a/compiler/noirc_frontend/src/elaborator/statements.rs b/compiler/noirc_frontend/src/elaborator/statements.rs index 55b641ca3d4..204a7f9cd75 100644 --- a/compiler/noirc_frontend/src/elaborator/statements.rs +++ b/compiler/noirc_frontend/src/elaborator/statements.rs @@ -3,7 +3,8 @@ use noirc_errors::{Location, Span, Spanned}; use crate::{ ast::{ AssignStatement, BinaryOpKind, ConstrainKind, ConstrainStatement, Expression, - ExpressionKind, InfixExpression, LValue, + ExpressionKind, ForLoopStatement, ForRange, InfixExpression, LValue, LetStatement, Path, + Statement, StatementKind, }, hir::{ resolution::errors::ResolverError, @@ -13,11 +14,9 @@ use crate::{ expr::HirIdent, stmt::{ HirAssignStatement, HirConstrainStatement, HirForStatement, HirLValue, HirLetStatement, + HirStatement, }, }, - macros_api::{ - ForLoopStatement, ForRange, HirStatement, LetStatement, Path, Statement, StatementKind, - }, node_interner::{DefinitionId, DefinitionKind, GlobalId, StmtId}, Type, }; diff --git a/compiler/noirc_frontend/src/elaborator/trait_impls.rs b/compiler/noirc_frontend/src/elaborator/trait_impls.rs index aa7e1cb89c5..2f9c927fae6 100644 --- a/compiler/noirc_frontend/src/elaborator/trait_impls.rs +++ b/compiler/noirc_frontend/src/elaborator/trait_impls.rs @@ -1,8 +1,7 @@ use crate::{ - ast::UnresolvedTypeExpression, + ast::{Ident, UnresolvedType, UnresolvedTypeData, UnresolvedTypeExpression}, graph::CrateId, hir::def_collector::{dc_crate::UnresolvedTraitImpl, errors::DefCollectorErrorKind}, - macros_api::{Ident, UnresolvedType, UnresolvedTypeData}, node_interner::TraitImplId, ResolvedGeneric, }; diff --git a/compiler/noirc_frontend/src/elaborator/traits.rs b/compiler/noirc_frontend/src/elaborator/traits.rs index d7c8769620d..21e2edf3822 100644 --- a/compiler/noirc_frontend/src/elaborator/traits.rs +++ b/compiler/noirc_frontend/src/elaborator/traits.rs @@ -5,15 +5,13 @@ use noirc_errors::{Location, Span}; use crate::{ ast::{ - FunctionKind, TraitItem, UnresolvedGeneric, UnresolvedGenerics, UnresolvedTraitConstraint, + BlockExpression, FunctionDefinition, FunctionKind, FunctionReturnType, Ident, + ItemVisibility, NoirFunction, TraitItem, UnresolvedGeneric, UnresolvedGenerics, + UnresolvedTraitConstraint, UnresolvedType, }, hir::{def_collector::dc_crate::UnresolvedTrait, type_check::TypeCheckError}, hir_def::{function::Parameters, traits::TraitFunction}, - macros_api::{ - BlockExpression, FunctionDefinition, FunctionReturnType, Ident, ItemVisibility, - NodeInterner, NoirFunction, UnresolvedType, - }, - node_interner::{FuncId, ReferenceId, TraitId}, + node_interner::{FuncId, NodeInterner, ReferenceId, TraitId}, Kind, ResolvedGeneric, Type, TypeBindings, TypeVariableKind, }; diff --git a/compiler/noirc_frontend/src/elaborator/types.rs b/compiler/noirc_frontend/src/elaborator/types.rs index 264b83956f8..80a9133d0d7 100644 --- a/compiler/noirc_frontend/src/elaborator/types.rs +++ b/compiler/noirc_frontend/src/elaborator/types.rs @@ -7,8 +7,9 @@ use rustc_hash::FxHashMap as HashMap; use crate::{ ast::{ - AsTraitPath, BinaryOpKind, GenericTypeArgs, IntegerBitSize, UnresolvedGeneric, - UnresolvedGenerics, UnresolvedTypeExpression, + AsTraitPath, BinaryOpKind, GenericTypeArgs, Ident, IntegerBitSize, Path, PathKind, + Signedness, UnaryOp, UnresolvedGeneric, UnresolvedGenerics, UnresolvedType, + UnresolvedTypeData, UnresolvedTypeExpression, }, hir::{ comptime::{Interpreter, Value}, @@ -22,20 +23,18 @@ use crate::{ }, hir_def::{ expr::{ - HirBinaryOp, HirCallExpression, HirMemberAccess, HirMethodReference, - HirPrefixExpression, + HirBinaryOp, HirCallExpression, HirExpression, HirLiteral, HirMemberAccess, + HirMethodReference, HirPrefixExpression, }, function::{FuncMeta, Parameters}, + stmt::HirStatement, traits::{NamedType, TraitConstraint}, }, - macros_api::{ - HirExpression, HirLiteral, HirStatement, Ident, NodeInterner, Path, PathKind, - SecondaryAttribute, Signedness, UnaryOp, UnresolvedType, UnresolvedTypeData, - }, node_interner::{ - DefinitionKind, DependencyId, ExprId, FuncId, GlobalId, ImplSearchErrorKind, TraitId, - TraitImplKind, TraitMethodId, + DefinitionKind, DependencyId, ExprId, FuncId, GlobalId, ImplSearchErrorKind, NodeInterner, + TraitId, TraitImplKind, TraitMethodId, }, + token::SecondaryAttribute, Generics, Kind, ResolvedGeneric, Type, TypeBinding, TypeBindings, TypeVariable, TypeVariableKind, UnificationError, }; diff --git a/compiler/noirc_frontend/src/elaborator/unquote.rs b/compiler/noirc_frontend/src/elaborator/unquote.rs index fd7e02df905..982ad3d2e1f 100644 --- a/compiler/noirc_frontend/src/elaborator/unquote.rs +++ b/compiler/noirc_frontend/src/elaborator/unquote.rs @@ -1,5 +1,5 @@ use crate::{ - macros_api::Path, + ast::Path, token::{SpannedToken, Token, Tokens}, }; diff --git a/compiler/noirc_frontend/src/hir/comptime/display.rs b/compiler/noirc_frontend/src/hir/comptime/display.rs index 105f6e09395..3f2ecb395d0 100644 --- a/compiler/noirc_frontend/src/hir/comptime/display.rs +++ b/compiler/noirc_frontend/src/hir/comptime/display.rs @@ -13,8 +13,7 @@ use crate::{ UnresolvedTypeData, }, hir_def::traits::TraitConstraint, - macros_api::NodeInterner, - node_interner::InternedStatementKind, + node_interner::{InternedStatementKind, NodeInterner}, token::{Keyword, Token}, Type, }; diff --git a/compiler/noirc_frontend/src/hir/comptime/hir_to_display_ast.rs b/compiler/noirc_frontend/src/hir/comptime/hir_to_display_ast.rs index 4344d19829a..90deef2deb7 100644 --- a/compiler/noirc_frontend/src/hir/comptime/hir_to_display_ast.rs +++ b/compiler/noirc_frontend/src/hir/comptime/hir_to_display_ast.rs @@ -9,10 +9,11 @@ use crate::ast::{ UnresolvedType, UnresolvedTypeData, UnresolvedTypeExpression, }; use crate::ast::{ConstrainStatement, Expression, Statement, StatementKind}; -use crate::hir_def::expr::{HirArrayLiteral, HirBlockExpression, HirExpression, HirIdent}; +use crate::hir_def::expr::{ + HirArrayLiteral, HirBlockExpression, HirExpression, HirIdent, HirLiteral, +}; use crate::hir_def::stmt::{HirLValue, HirPattern, HirStatement}; use crate::hir_def::types::{Type, TypeBinding}; -use crate::macros_api::HirLiteral; use crate::node_interner::{ExprId, NodeInterner, StmtId}; // TODO: diff --git a/compiler/noirc_frontend/src/hir/comptime/interpreter.rs b/compiler/noirc_frontend/src/hir/comptime/interpreter.rs index 16f154e3ec0..473e1f25e34 100644 --- a/compiler/noirc_frontend/src/hir/comptime/interpreter.rs +++ b/compiler/noirc_frontend/src/hir/comptime/interpreter.rs @@ -8,14 +8,13 @@ use iter_extended::try_vecmap; use noirc_errors::Location; use rustc_hash::FxHashMap as HashMap; -use crate::ast::{BinaryOpKind, FunctionKind, IntegerBitSize, Signedness}; +use crate::ast::{BinaryOpKind, FunctionKind, IntegerBitSize, Signedness, UnaryOp}; use crate::elaborator::Elaborator; use crate::graph::CrateId; use crate::hir::def_map::ModuleId; use crate::hir::type_check::TypeCheckError; use crate::hir_def::expr::ImplKind; use crate::hir_def::function::FunctionBody; -use crate::macros_api::UnaryOp; use crate::monomorphization::{ perform_impl_bindings, perform_instantiation_bindings, resolve_trait_method, undo_instantiation_bindings, @@ -27,16 +26,15 @@ use crate::{ expr::{ HirArrayLiteral, HirBlockExpression, HirCallExpression, HirCastExpression, HirConstructorExpression, HirExpression, HirIdent, HirIfExpression, HirIndexExpression, - HirInfixExpression, HirLambda, HirMemberAccess, HirMethodCallExpression, + HirInfixExpression, HirLambda, HirLiteral, HirMemberAccess, HirMethodCallExpression, HirPrefixExpression, }, stmt::{ HirAssignStatement, HirConstrainStatement, HirForStatement, HirLValue, HirLetStatement, - HirPattern, + HirPattern, HirStatement, }, }, - macros_api::{HirLiteral, HirStatement, NodeInterner}, - node_interner::{DefinitionId, DefinitionKind, ExprId, FuncId, StmtId}, + node_interner::{DefinitionId, DefinitionKind, ExprId, FuncId, NodeInterner, StmtId}, Shared, Type, TypeBinding, TypeBindings, TypeVariableKind, }; diff --git a/compiler/noirc_frontend/src/hir/comptime/interpreter/builtin.rs b/compiler/noirc_frontend/src/hir/comptime/interpreter/builtin.rs index 9960486120e..4c81d4c3ed3 100644 --- a/compiler/noirc_frontend/src/hir/comptime/interpreter/builtin.rs +++ b/compiler/noirc_frontend/src/hir/comptime/interpreter/builtin.rs @@ -20,8 +20,9 @@ use rustc_hash::FxHashMap as HashMap; use crate::{ ast::{ ArrayLiteral, BlockExpression, ConstrainKind, Expression, ExpressionKind, ForRange, - FunctionKind, FunctionReturnType, IntegerBitSize, LValue, Literal, Pattern, Statement, - StatementKind, UnaryOp, UnresolvedType, UnresolvedTypeData, Visibility, + FunctionKind, FunctionReturnType, Ident, IntegerBitSize, LValue, Literal, Pattern, + Signedness, Statement, StatementKind, UnaryOp, UnresolvedType, UnresolvedTypeData, + Visibility, }, hir::{ comptime::{ @@ -30,10 +31,13 @@ use crate::{ InterpreterError, Value, }, def_collector::dc_crate::CollectedItems, + def_map::ModuleDefId, }, - hir_def::function::FunctionBody, - macros_api::{HirExpression, HirLiteral, Ident, ModuleDefId, NodeInterner, Signedness}, - node_interner::{DefinitionKind, TraitImplKind}, + hir_def::{ + expr::{HirExpression, HirLiteral}, + function::FunctionBody, + }, + node_interner::{DefinitionKind, NodeInterner, TraitImplKind}, parser, token::{Attribute, SecondaryAttribute, Token}, Kind, QuotedType, ResolvedGeneric, Shared, Type, TypeVariable, diff --git a/compiler/noirc_frontend/src/hir/comptime/interpreter/builtin/builtin_helpers.rs b/compiler/noirc_frontend/src/hir/comptime/interpreter/builtin/builtin_helpers.rs index 20303e49e15..a355b23b74f 100644 --- a/compiler/noirc_frontend/src/hir/comptime/interpreter/builtin/builtin_helpers.rs +++ b/compiler/noirc_frontend/src/hir/comptime/interpreter/builtin/builtin_helpers.rs @@ -24,8 +24,7 @@ use crate::{ function::{FuncMeta, FunctionBody}, stmt::HirPattern, }, - macros_api::{NodeInterner, StructId}, - node_interner::{FuncId, TraitId, TraitImplId}, + node_interner::{FuncId, NodeInterner, StructId, TraitId, TraitImplId}, parser::NoirParser, token::{SecondaryAttribute, Token, Tokens}, QuotedType, Type, diff --git a/compiler/noirc_frontend/src/hir/comptime/interpreter/foreign.rs b/compiler/noirc_frontend/src/hir/comptime/interpreter/foreign.rs index 5ae60bb4d00..d1ab6a1dabd 100644 --- a/compiler/noirc_frontend/src/hir/comptime/interpreter/foreign.rs +++ b/compiler/noirc_frontend/src/hir/comptime/interpreter/foreign.rs @@ -6,7 +6,7 @@ use noirc_errors::Location; use crate::{ hir::comptime::{errors::IResult, InterpreterError, Value}, - macros_api::NodeInterner, + node_interner::NodeInterner, }; use super::builtin::builtin_helpers::{ diff --git a/compiler/noirc_frontend/src/hir/comptime/value.rs b/compiler/noirc_frontend/src/hir/comptime/value.rs index f01e188e498..4c968234f04 100644 --- a/compiler/noirc_frontend/src/hir/comptime/value.rs +++ b/compiler/noirc_frontend/src/hir/comptime/value.rs @@ -9,16 +9,16 @@ use strum_macros::Display; use crate::{ ast::{ - ArrayLiteral, BlockExpression, ConstructorExpression, Ident, IntegerBitSize, LValue, - Pattern, Signedness, Statement, StatementKind, UnresolvedType, UnresolvedTypeData, + ArrayLiteral, BlockExpression, ConstructorExpression, Expression, ExpressionKind, Ident, + IntegerBitSize, LValue, Literal, Path, Pattern, Signedness, Statement, StatementKind, + UnresolvedType, UnresolvedTypeData, }, hir::{def_map::ModuleId, type_check::generics::TraitGenerics}, - hir_def::expr::{HirArrayLiteral, HirConstructorExpression, HirIdent, HirLambda, ImplKind}, - macros_api::{ - Expression, ExpressionKind, HirExpression, HirLiteral, Literal, NodeInterner, Path, - StructId, + hir_def::expr::{ + HirArrayLiteral, HirConstructorExpression, HirExpression, HirIdent, HirLambda, HirLiteral, + ImplKind, }, - node_interner::{ExprId, FuncId, StmtId, TraitId, TraitImplId}, + node_interner::{ExprId, FuncId, NodeInterner, StmtId, StructId, TraitId, TraitImplId}, parser::{self, NoirParser, TopLevelStatement}, token::{SpannedToken, Token, Tokens}, Kind, QuotedType, Shared, Type, TypeBindings, diff --git a/compiler/noirc_frontend/src/hir/def_collector/dc_crate.rs b/compiler/noirc_frontend/src/hir/def_collector/dc_crate.rs index faf72e86fb4..267c9bc84b8 100644 --- a/compiler/noirc_frontend/src/hir/def_collector/dc_crate.rs +++ b/compiler/noirc_frontend/src/hir/def_collector/dc_crate.rs @@ -14,7 +14,7 @@ use crate::{Generics, Type}; use crate::hir::resolution::import::{resolve_import, ImportDirective, PathResolution}; use crate::hir::Context; -use crate::macros_api::Expression; +use crate::ast::Expression; use crate::node_interner::{ FuncId, GlobalId, ModuleAttributes, NodeInterner, ReferenceId, StructId, TraitId, TraitImplId, TypeAliasId, @@ -507,7 +507,7 @@ impl DefCollector { } fn add_import_reference( - def_id: crate::macros_api::ModuleDefId, + def_id: crate::hir::def_map::ModuleDefId, name: &Ident, interner: &mut NodeInterner, file_id: FileId, diff --git a/compiler/noirc_frontend/src/hir/def_collector/dc_mod.rs b/compiler/noirc_frontend/src/hir/def_collector/dc_mod.rs index b530e023152..dff63e045fe 100644 --- a/compiler/noirc_frontend/src/hir/def_collector/dc_mod.rs +++ b/compiler/noirc_frontend/src/hir/def_collector/dc_mod.rs @@ -11,13 +11,12 @@ use num_traits::Num; use rustc_hash::FxHashMap as HashMap; use crate::ast::{ - Documented, FunctionDefinition, Ident, ItemVisibility, LetStatement, ModuleDeclaration, - NoirFunction, NoirStruct, NoirTrait, NoirTraitImpl, NoirTypeAlias, Pattern, TraitImplItemKind, - TraitItem, TypeImpl, + Documented, Expression, FunctionDefinition, Ident, ItemVisibility, LetStatement, + ModuleDeclaration, NoirFunction, NoirStruct, NoirTrait, NoirTraitImpl, NoirTypeAlias, Pattern, + TraitImplItemKind, TraitItem, TypeImpl, UnresolvedType, UnresolvedTypeData, }; use crate::hir::resolution::errors::ResolverError; -use crate::macros_api::{Expression, NodeInterner, StructId, UnresolvedType, UnresolvedTypeData}; -use crate::node_interner::{ModuleAttributes, ReferenceId}; +use crate::node_interner::{ModuleAttributes, NodeInterner, ReferenceId, StructId}; use crate::token::SecondaryAttribute; use crate::usage_tracker::UnusedItem; use crate::{ diff --git a/compiler/noirc_frontend/src/hir/type_check/errors.rs b/compiler/noirc_frontend/src/hir/type_check/errors.rs index 00e73e682e8..54699792901 100644 --- a/compiler/noirc_frontend/src/hir/type_check/errors.rs +++ b/compiler/noirc_frontend/src/hir/type_check/errors.rs @@ -5,14 +5,14 @@ use noirc_errors::CustomDiagnostic as Diagnostic; use noirc_errors::Span; use thiserror::Error; -use crate::ast::ConstrainKind; -use crate::ast::{BinaryOpKind, FunctionReturnType, IntegerBitSize, Signedness}; +use crate::ast::{ + BinaryOpKind, ConstrainKind, FunctionReturnType, Ident, IntegerBitSize, Signedness, +}; use crate::hir::resolution::errors::ResolverError; use crate::hir_def::expr::HirBinaryOp; use crate::hir_def::traits::TraitConstraint; use crate::hir_def::types::Type; -use crate::macros_api::Ident; -use crate::macros_api::NodeInterner; +use crate::node_interner::NodeInterner; #[derive(Error, Debug, Clone, PartialEq, Eq)] pub enum Source { diff --git a/compiler/noirc_frontend/src/hir/type_check/generics.rs b/compiler/noirc_frontend/src/hir/type_check/generics.rs index b86e2350279..86fc2d25d4e 100644 --- a/compiler/noirc_frontend/src/hir/type_check/generics.rs +++ b/compiler/noirc_frontend/src/hir/type_check/generics.rs @@ -4,8 +4,7 @@ use iter_extended::vecmap; use crate::{ hir_def::traits::NamedType, - macros_api::NodeInterner, - node_interner::{FuncId, TraitId, TypeAliasId}, + node_interner::{FuncId, NodeInterner, TraitId, TypeAliasId}, ResolvedGeneric, StructType, Type, }; diff --git a/compiler/noirc_frontend/src/hir_def/function.rs b/compiler/noirc_frontend/src/hir_def/function.rs index 39c87607446..6ecfdefe996 100644 --- a/compiler/noirc_frontend/src/hir_def/function.rs +++ b/compiler/noirc_frontend/src/hir_def/function.rs @@ -5,11 +5,10 @@ use noirc_errors::{Location, Span}; use super::expr::{HirBlockExpression, HirExpression, HirIdent}; use super::stmt::HirPattern; use super::traits::TraitConstraint; -use crate::ast::{FunctionKind, FunctionReturnType, Visibility}; +use crate::ast::{BlockExpression, FunctionKind, FunctionReturnType, Visibility}; use crate::graph::CrateId; use crate::hir::def_map::LocalModuleId; -use crate::macros_api::{BlockExpression, StructId}; -use crate::node_interner::{ExprId, NodeInterner, TraitId, TraitImplId}; +use crate::node_interner::{ExprId, NodeInterner, StructId, TraitId, TraitImplId}; use crate::token::CustomAttribute; use crate::{ResolvedGeneric, Type}; diff --git a/compiler/noirc_frontend/src/hir_def/stmt.rs b/compiler/noirc_frontend/src/hir_def/stmt.rs index 0b4dbeb3006..b97e99583bb 100644 --- a/compiler/noirc_frontend/src/hir_def/stmt.rs +++ b/compiler/noirc_frontend/src/hir_def/stmt.rs @@ -1,7 +1,7 @@ use super::expr::HirIdent; use crate::ast::Ident; -use crate::macros_api::SecondaryAttribute; use crate::node_interner::{ExprId, StmtId}; +use crate::token::SecondaryAttribute; use crate::Type; use fm::FileId; use noirc_errors::{Location, Span}; diff --git a/compiler/noirc_frontend/src/lib.rs b/compiler/noirc_frontend/src/lib.rs index 4391c760701..9d98b125e32 100644 --- a/compiler/noirc_frontend/src/lib.rs +++ b/compiler/noirc_frontend/src/lib.rs @@ -36,31 +36,3 @@ pub use hir_def::types::*; // Unit tests that involve all modules pub mod tests; - -// API for experimental macros feature -pub mod macros_api { - - pub use acvm::FieldElement; - pub use fm::FileId; - pub use noirc_errors::Span; - - pub use crate::graph::CrateId; - pub use crate::hir_def::expr::{HirExpression, HirLiteral}; - pub use crate::hir_def::stmt::HirStatement; - pub use crate::node_interner::{NodeInterner, StructId}; - pub use crate::parser::{parse_program, SortedModule}; - pub use crate::token::SecondaryAttribute; - - pub use crate::ast::{ - BlockExpression, CallExpression, CastExpression, Documented, Expression, ExpressionKind, - FunctionReturnType, Ident, IndexExpression, ItemVisibility, LetStatement, Literal, - MemberAccessExpression, MethodCallExpression, NoirFunction, Path, PathKind, Pattern, - Statement, UnresolvedType, UnresolvedTypeData, Visibility, - }; - pub use crate::ast::{ - ForLoopStatement, ForRange, FunctionDefinition, ImportStatement, NoirStruct, Param, - PrefixExpression, Signedness, StatementKind, TypeImpl, UnaryOp, - }; - pub use crate::hir::{def_map::ModuleDefId, Context as HirContext}; - pub use crate::{StructType, Type}; -} diff --git a/compiler/noirc_frontend/src/locations.rs b/compiler/noirc_frontend/src/locations.rs index cba667d5dcb..65adf4ca9c4 100644 --- a/compiler/noirc_frontend/src/locations.rs +++ b/compiler/noirc_frontend/src/locations.rs @@ -6,8 +6,9 @@ use rustc_hash::FxHashMap as HashMap; use crate::{ ast::{FunctionDefinition, ItemVisibility}, hir::def_map::{ModuleDefId, ModuleId}, - macros_api::{NodeInterner, StructId}, - node_interner::{DefinitionId, FuncId, GlobalId, ReferenceId, TraitId, TypeAliasId}, + node_interner::{ + DefinitionId, FuncId, GlobalId, NodeInterner, ReferenceId, StructId, TraitId, TypeAliasId, + }, }; use petgraph::prelude::NodeIndex as PetGraphIndex; diff --git a/compiler/noirc_frontend/src/node_interner.rs b/compiler/noirc_frontend/src/node_interner.rs index 8d665ceacbf..295678c1412 100644 --- a/compiler/noirc_frontend/src/node_interner.rs +++ b/compiler/noirc_frontend/src/node_interner.rs @@ -13,22 +13,17 @@ use petgraph::prelude::DiGraph; use petgraph::prelude::NodeIndex as PetGraphIndex; use rustc_hash::FxHashMap as HashMap; -use crate::ast::ExpressionKind; -use crate::ast::Ident; -use crate::ast::LValue; -use crate::ast::Pattern; -use crate::ast::StatementKind; -use crate::ast::UnresolvedTypeData; +use crate::ast::{ + ExpressionKind, Ident, LValue, Pattern, StatementKind, UnaryOp, UnresolvedTypeData, +}; use crate::graph::CrateId; use crate::hir::comptime; use crate::hir::def_collector::dc_crate::CompilationError; use crate::hir::def_collector::dc_crate::{UnresolvedStruct, UnresolvedTrait, UnresolvedTypeAlias}; use crate::hir::def_map::DefMaps; -use crate::hir::def_map::{LocalModuleId, ModuleId}; +use crate::hir::def_map::{LocalModuleId, ModuleDefId, ModuleId}; use crate::hir::type_check::generics::TraitGenerics; use crate::hir_def::traits::NamedType; -use crate::macros_api::ModuleDefId; -use crate::macros_api::UnaryOp; use crate::usage_tracker::UnusedItem; use crate::usage_tracker::UsageTracker; use crate::QuotedType; diff --git a/compiler/noirc_frontend/src/parser/parser/attributes.rs b/compiler/noirc_frontend/src/parser/parser/attributes.rs index 66d0ca29ca6..dc363248d72 100644 --- a/compiler/noirc_frontend/src/parser/parser/attributes.rs +++ b/compiler/noirc_frontend/src/parser/parser/attributes.rs @@ -2,9 +2,8 @@ use chumsky::Parser; use noirc_errors::Span; use crate::{ - macros_api::SecondaryAttribute, parser::{NoirParser, ParserError, ParserErrorReason}, - token::{Attribute, Attributes, Token, TokenKind}, + token::{Attribute, Attributes, SecondaryAttribute, Token, TokenKind}, }; use super::primitives::token_kind; diff --git a/compiler/noirc_frontend/src/parser/parser/function.rs b/compiler/noirc_frontend/src/parser/parser/function.rs index dc8b968ea7a..7b1f67a48bd 100644 --- a/compiler/noirc_frontend/src/parser/parser/function.rs +++ b/compiler/noirc_frontend/src/parser/parser/function.rs @@ -14,9 +14,9 @@ use crate::{ }; use crate::{ ast::{ - FunctionDefinition, FunctionReturnType, ItemVisibility, NoirFunction, Param, Visibility, + FunctionDefinition, FunctionReturnType, ItemVisibility, NoirFunction, Param, + UnresolvedTypeData, Visibility, }, - macros_api::UnresolvedTypeData, parser::{ParserError, ParserErrorReason}, }; use crate::{ diff --git a/compiler/noirc_frontend/src/parser/parser/lambdas.rs b/compiler/noirc_frontend/src/parser/parser/lambdas.rs index 5ef0b918375..68b5724edc6 100644 --- a/compiler/noirc_frontend/src/parser/parser/lambdas.rs +++ b/compiler/noirc_frontend/src/parser/parser/lambdas.rs @@ -1,8 +1,7 @@ use chumsky::{primitive::just, Parser}; use super::{parse_type, pattern}; -use crate::ast::{Expression, ExpressionKind, Lambda, Pattern, UnresolvedType}; -use crate::macros_api::UnresolvedTypeData; +use crate::ast::{Expression, ExpressionKind, Lambda, Pattern, UnresolvedType, UnresolvedTypeData}; use crate::{ parser::{labels::ParsingRuleLabel, parameter_name_recovery, parameter_recovery, NoirParser}, token::Token, diff --git a/compiler/noirc_frontend/src/parser/parser/path.rs b/compiler/noirc_frontend/src/parser/parser/path.rs index 1c9c24f5376..4babd0f6730 100644 --- a/compiler/noirc_frontend/src/parser/parser/path.rs +++ b/compiler/noirc_frontend/src/parser/parser/path.rs @@ -1,5 +1,6 @@ -use crate::ast::{AsTraitPath, Ident, Path, PathKind, PathSegment, TypePath, UnresolvedType}; -use crate::macros_api::ExpressionKind; +use crate::ast::{ + AsTraitPath, ExpressionKind, Ident, Path, PathKind, PathSegment, TypePath, UnresolvedType, +}; use crate::parser::{NoirParser, ParserError, ParserErrorReason}; use crate::token::{Keyword, Token}; diff --git a/compiler/noirc_frontend/src/parser/parser/primitives.rs b/compiler/noirc_frontend/src/parser/parser/primitives.rs index 7fcca89f70c..5a040f23619 100644 --- a/compiler/noirc_frontend/src/parser/parser/primitives.rs +++ b/compiler/noirc_frontend/src/parser/parser/primitives.rs @@ -1,7 +1,8 @@ use chumsky::prelude::*; -use crate::ast::{ExpressionKind, GenericTypeArgs, Ident, PathSegment, UnaryOp}; -use crate::macros_api::{StatementKind, UnresolvedType}; +use crate::ast::{ + ExpressionKind, GenericTypeArgs, Ident, PathSegment, StatementKind, UnaryOp, UnresolvedType, +}; use crate::parser::ParserErrorReason; use crate::{ parser::{labels::ParsingRuleLabel, ExprParser, NoirParser, ParserError}, diff --git a/compiler/noirc_frontend/src/parser/parser/traits.rs b/compiler/noirc_frontend/src/parser/parser/traits.rs index b95319f6da0..78453d7f7a2 100644 --- a/compiler/noirc_frontend/src/parser/parser/traits.rs +++ b/compiler/noirc_frontend/src/parser/parser/traits.rs @@ -10,10 +10,9 @@ use super::{ }; use crate::ast::{ - Documented, Expression, ItemVisibility, NoirTrait, NoirTraitImpl, TraitBound, TraitImplItem, - TraitImplItemKind, TraitItem, UnresolvedTraitConstraint, UnresolvedType, + Documented, Expression, ItemVisibility, NoirTrait, NoirTraitImpl, Pattern, TraitBound, + TraitImplItem, TraitImplItemKind, TraitItem, UnresolvedTraitConstraint, UnresolvedType, }; -use crate::macros_api::Pattern; use crate::parser::spanned; use crate::{ parser::{ diff --git a/compiler/noirc_frontend/src/usage_tracker.rs b/compiler/noirc_frontend/src/usage_tracker.rs index 275ca1f964b..0a112c6937d 100644 --- a/compiler/noirc_frontend/src/usage_tracker.rs +++ b/compiler/noirc_frontend/src/usage_tracker.rs @@ -3,8 +3,7 @@ use std::collections::HashMap; use crate::{ ast::{Ident, ItemVisibility}, hir::def_map::ModuleId, - macros_api::StructId, - node_interner::{FuncId, GlobalId, TraitId, TypeAliasId}, + node_interner::{FuncId, GlobalId, StructId, TraitId, TypeAliasId}, }; #[derive(Debug, Copy, Clone, PartialEq, Eq)] diff --git a/tooling/lsp/src/modules.rs b/tooling/lsp/src/modules.rs index f1eff3b5a7d..9f9a826d6ca 100644 --- a/tooling/lsp/src/modules.rs +++ b/tooling/lsp/src/modules.rs @@ -3,9 +3,8 @@ use std::collections::BTreeMap; use noirc_frontend::{ ast::ItemVisibility, graph::{CrateId, Dependency}, - hir::def_map::{CrateDefMap, ModuleId}, - macros_api::{ModuleDefId, NodeInterner}, - node_interner::ReferenceId, + hir::def_map::{CrateDefMap, ModuleDefId, ModuleId}, + node_interner::{NodeInterner, ReferenceId}, }; use crate::visibility::is_visible; diff --git a/tooling/lsp/src/requests/code_action.rs b/tooling/lsp/src/requests/code_action.rs index 64eccab8947..9299dc76368 100644 --- a/tooling/lsp/src/requests/code_action.rs +++ b/tooling/lsp/src/requests/code_action.rs @@ -15,7 +15,7 @@ use noirc_frontend::{ ast::{ConstructorExpression, ItemVisibility, NoirTraitImpl, Path, UseTree, Visitor}, graph::CrateId, hir::def_map::{CrateDefMap, LocalModuleId, ModuleId}, - macros_api::NodeInterner, + node_interner::NodeInterner, }; use noirc_frontend::{ parser::{Item, ItemKind, ParsedSubModule}, diff --git a/tooling/lsp/src/requests/code_action/import_or_qualify.rs b/tooling/lsp/src/requests/code_action/import_or_qualify.rs index 0d97ccde2ed..769f801a6f1 100644 --- a/tooling/lsp/src/requests/code_action/import_or_qualify.rs +++ b/tooling/lsp/src/requests/code_action/import_or_qualify.rs @@ -2,7 +2,7 @@ use lsp_types::{Position, Range, TextEdit}; use noirc_errors::Location; use noirc_frontend::{ ast::{Ident, Path}, - macros_api::ModuleDefId, + hir::def_map::ModuleDefId, }; use crate::{ diff --git a/tooling/lsp/src/requests/code_lens_request.rs b/tooling/lsp/src/requests/code_lens_request.rs index 4565569e67b..42f2af3a7bf 100644 --- a/tooling/lsp/src/requests/code_lens_request.rs +++ b/tooling/lsp/src/requests/code_lens_request.rs @@ -89,8 +89,8 @@ fn on_code_lens_request_inner( } pub(crate) fn collect_lenses_for_package( - context: &noirc_frontend::macros_api::HirContext, - crate_id: noirc_frontend::macros_api::CrateId, + context: &noirc_frontend::hir::Context, + crate_id: noirc_frontend::graph::CrateId, workspace: &Workspace, package: &Package, file_path: Option<&std::path::PathBuf>, diff --git a/tooling/lsp/src/requests/completion.rs b/tooling/lsp/src/requests/completion.rs index 588f5b18f1b..2db1665b639 100644 --- a/tooling/lsp/src/requests/completion.rs +++ b/tooling/lsp/src/requests/completion.rs @@ -24,9 +24,9 @@ use noirc_frontend::{ UseTreeKind, Visitor, }, graph::{CrateId, Dependency}, - hir::def_map::{CrateDefMap, LocalModuleId, ModuleId}, + hir::def_map::{CrateDefMap, LocalModuleId, ModuleDefId, ModuleId}, hir_def::traits::Trait, - macros_api::{ModuleDefId, NodeInterner}, + node_interner::NodeInterner, node_interner::ReferenceId, parser::{Item, ItemKind, ParsedSubModule}, token::{CustomAttribute, Token, Tokens}, diff --git a/tooling/lsp/src/requests/completion/auto_import.rs b/tooling/lsp/src/requests/completion/auto_import.rs index 20b126a248d..e2dd582f2f3 100644 --- a/tooling/lsp/src/requests/completion/auto_import.rs +++ b/tooling/lsp/src/requests/completion/auto_import.rs @@ -1,5 +1,5 @@ use lsp_types::{Position, Range, TextEdit}; -use noirc_frontend::macros_api::ModuleDefId; +use noirc_frontend::hir::def_map::ModuleDefId; use crate::modules::{relative_module_full_path, relative_module_id_path}; diff --git a/tooling/lsp/src/requests/completion/completion_items.rs b/tooling/lsp/src/requests/completion/completion_items.rs index 809988c34a5..f281f5e3abf 100644 --- a/tooling/lsp/src/requests/completion/completion_items.rs +++ b/tooling/lsp/src/requests/completion/completion_items.rs @@ -4,10 +4,9 @@ use lsp_types::{ }; use noirc_frontend::{ ast::AttributeTarget, - hir::def_map::ModuleId, + hir::def_map::{ModuleDefId, ModuleId}, hir_def::{function::FuncMeta, stmt::HirPattern}, - macros_api::{ModuleDefId, StructId}, - node_interner::{FuncId, GlobalId, ReferenceId, TraitId, TypeAliasId}, + node_interner::{FuncId, GlobalId, ReferenceId, StructId, TraitId, TypeAliasId}, QuotedType, Type, }; diff --git a/tooling/lsp/src/requests/hover.rs b/tooling/lsp/src/requests/hover.rs index 2628c9b2ab6..25a401f488e 100644 --- a/tooling/lsp/src/requests/hover.rs +++ b/tooling/lsp/src/requests/hover.rs @@ -7,11 +7,15 @@ use noirc_frontend::{ ast::Visibility, elaborator::types::try_eval_array_length_id, hir::def_map::ModuleId, - hir_def::{expr::HirArrayLiteral, stmt::HirPattern, traits::Trait}, - macros_api::{HirExpression, HirLiteral, NodeInterner, StructId}, + hir_def::{ + expr::{HirArrayLiteral, HirExpression, HirLiteral}, + stmt::HirPattern, + traits::Trait, + }, node_interner::{ DefinitionId, DefinitionKind, ExprId, FuncId, GlobalId, ReferenceId, TraitId, TypeAliasId, }, + node_interner::{NodeInterner, StructId}, Generics, Shared, StructType, Type, TypeAlias, TypeBinding, TypeVariable, }; diff --git a/tooling/lsp/src/requests/inlay_hint.rs b/tooling/lsp/src/requests/inlay_hint.rs index 2eef4f6e262..ea73cc688ef 100644 --- a/tooling/lsp/src/requests/inlay_hint.rs +++ b/tooling/lsp/src/requests/inlay_hint.rs @@ -15,8 +15,7 @@ use noirc_frontend::{ UnresolvedTypeData, Visitor, }, hir_def::stmt::HirPattern, - macros_api::NodeInterner, - node_interner::ReferenceId, + node_interner::{NodeInterner, ReferenceId}, parser::{Item, ParsedSubModule}, Type, TypeBinding, TypeVariable, TypeVariableKind, }; diff --git a/tooling/lsp/src/requests/mod.rs b/tooling/lsp/src/requests/mod.rs index 576d026081d..597d8355468 100644 --- a/tooling/lsp/src/requests/mod.rs +++ b/tooling/lsp/src/requests/mod.rs @@ -18,7 +18,7 @@ use nargo_fmt::Config; use noirc_frontend::graph::CrateId; use noirc_frontend::hir::def_map::CrateDefMap; -use noirc_frontend::{graph::Dependency, macros_api::NodeInterner}; +use noirc_frontend::{graph::Dependency, node_interner::NodeInterner}; use serde::{Deserialize, Serialize}; use crate::{ diff --git a/tooling/lsp/src/requests/signature_help.rs b/tooling/lsp/src/requests/signature_help.rs index b075fea1d1e..c0d40656c19 100644 --- a/tooling/lsp/src/requests/signature_help.rs +++ b/tooling/lsp/src/requests/signature_help.rs @@ -12,8 +12,7 @@ use noirc_frontend::{ MethodCallExpression, Statement, Visitor, }, hir_def::{function::FuncMeta, stmt::HirPattern}, - macros_api::NodeInterner, - node_interner::ReferenceId, + node_interner::{NodeInterner, ReferenceId}, parser::Item, ParsedModule, Type, }; diff --git a/tooling/lsp/src/trait_impl_method_stub_generator.rs b/tooling/lsp/src/trait_impl_method_stub_generator.rs index 56d2e5e1ea1..4fe039e7bd7 100644 --- a/tooling/lsp/src/trait_impl_method_stub_generator.rs +++ b/tooling/lsp/src/trait_impl_method_stub_generator.rs @@ -3,13 +3,13 @@ use std::collections::BTreeMap; use noirc_frontend::{ ast::NoirTraitImpl, graph::CrateId, + hir::def_map::ModuleDefId, hir::{ def_map::{CrateDefMap, ModuleId}, type_check::generics::TraitGenerics, }, hir_def::{function::FuncMeta, stmt::HirPattern, traits::Trait}, - macros_api::{ModuleDefId, NodeInterner}, - node_interner::{FunctionModifiers, ReferenceId}, + node_interner::{FunctionModifiers, NodeInterner, ReferenceId}, Kind, ResolvedGeneric, Type, TypeVariableKind, }; diff --git a/tooling/nargo_fmt/Cargo.toml b/tooling/nargo_fmt/Cargo.toml index 9868f259097..1e4d93b3125 100644 --- a/tooling/nargo_fmt/Cargo.toml +++ b/tooling/nargo_fmt/Cargo.toml @@ -11,6 +11,7 @@ workspace = true [dependencies] bytecount = "0.6.3" +noirc_errors.workspace = true noirc_frontend.workspace = true serde.workspace = true toml.workspace = true diff --git a/tooling/nargo_fmt/src/items.rs b/tooling/nargo_fmt/src/items.rs index 57757982e83..e68be7cdc95 100644 --- a/tooling/nargo_fmt/src/items.rs +++ b/tooling/nargo_fmt/src/items.rs @@ -1,4 +1,4 @@ -use noirc_frontend::macros_api::Span; +use noirc_errors::Span; use crate::{ utils::{comment_len, find_comment_end}, diff --git a/tooling/nargo_fmt/src/rewrite/expr.rs b/tooling/nargo_fmt/src/rewrite/expr.rs index 873b5c87056..98b50e92476 100644 --- a/tooling/nargo_fmt/src/rewrite/expr.rs +++ b/tooling/nargo_fmt/src/rewrite/expr.rs @@ -1,8 +1,9 @@ +use noirc_errors::Span; use noirc_frontend::ast::{ ArrayLiteral, BlockExpression, Expression, ExpressionKind, Literal, Path, PathKind, UnaryOp, UnresolvedType, }; -use noirc_frontend::{macros_api::Span, token::Token}; +use noirc_frontend::token::Token; use crate::rewrite; use crate::visitor::{ diff --git a/tooling/nargo_fmt/src/visitor/item.rs b/tooling/nargo_fmt/src/visitor/item.rs index 2feae4b390c..12ace814369 100644 --- a/tooling/nargo_fmt/src/visitor/item.rs +++ b/tooling/nargo_fmt/src/visitor/item.rs @@ -6,9 +6,8 @@ use crate::{ }, visitor::expr::{format_seq, NewlineMode}, }; -use noirc_frontend::{ - ast::{ItemVisibility, NoirFunction, TraitImplItemKind, Visibility}, - macros_api::UnresolvedTypeData, +use noirc_frontend::ast::{ + ItemVisibility, NoirFunction, TraitImplItemKind, UnresolvedTypeData, Visibility, }; use noirc_frontend::{ hir::resolution::errors::Span, diff --git a/tooling/nargo_fmt/src/visitor/stmt.rs b/tooling/nargo_fmt/src/visitor/stmt.rs index 8908aabd87c..7298be641d9 100644 --- a/tooling/nargo_fmt/src/visitor/stmt.rs +++ b/tooling/nargo_fmt/src/visitor/stmt.rs @@ -1,6 +1,6 @@ use std::iter::zip; -use noirc_frontend::macros_api::Span; +use noirc_errors::Span; use noirc_frontend::ast::{ConstrainKind, ConstrainStatement, ForRange, Statement, StatementKind};