Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add formatting on save #54

Closed
Savio-Sou opened this issue Dec 1, 2023 · 3 comments · Fixed by #55
Closed

Add formatting on save #54

Savio-Sou opened this issue Dec 1, 2023 · 3 comments · Fixed by #55
Labels
enhancement New feature or request

Comments

@Savio-Sou
Copy link
Contributor

Problem

Formatting on save is now supported on the LSP side: noir-lang/noir#3433

But it hasn't been integrated and exposed through this VS Code extension yet.

Happy Case

Add the feature.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@Savio-Sou Savio-Sou added the enhancement New feature or request label Dec 1, 2023
@Savio-Sou
Copy link
Contributor Author

@kobyhallx would you like to pick this up? Perhaps after your goto works.

@kobyhallx
Copy link
Contributor

Sure, should I put it over goto Def's ?

@Savio-Sou
Copy link
Contributor Author

Savio-Sou commented Dec 4, 2023 •
edited
Loading

Would be great to have this before next week's Tue (i.e. before Noir Beta). No need to reprioritize if that sounds manageable 🙌

@Thunkar Thunkar mentioned this issue Dec 11, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Added format configuration defaults for noir noir-lang/vscode-noir
2 participants
@Savio-Sou @kobyhallx