Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify what happens with ibc_channel_close for randomness channels #207

Open
webmaster128 opened this issue Apr 4, 2023 · 4 comments
Open

Comments

@webmaster128
Copy link
Collaborator

Disallow closing? Doe something with remaining balance?

@kaisbaccour
Copy link
Contributor

I think what we should have (maybe not a prio) is a way for the proxy (or maybe for gateway mnager) to transfer payment funds from a payment contract to another. this will be useful anytime a customer proxy wants to migrate the contract into a new address or change the chain_id.
Another option is less automatic but good enough for now is that IBC_close will burn the payment funds with then sends back the ash as proof of burn. with that the community will manually reimburse via governance the old proxy by refunding the new payment contract.

@webmaster128
Copy link
Collaborator Author

webmaster128 commented Apr 4, 2023

If you consider the dapp IBC counterparty on the other chain the ultimate customer and owner of the funds in the payment contract, we can just allow it to dens a TransferFunds IBC message on the same path it would usually use for RequestBeacon (see also #206). This should cover a lot of cases in which the channel and dapp contract is still healthy.

@kaisbaccour
Copy link
Contributor

Yeah good question if you want to consider dapps owners of those NOIS or not. I think it should be the same way it works for KLM or Lufthansa miles you earn. They are yours, you can use them but you cannot sell them but If you change your account you should be able to call the support and transfer them to your new account.

@webmaster128
Copy link
Collaborator Author

Right, TransferFunds can be something very custom, not a generic send. It should not be attractive to hack a dapp to get the NOIS out. Worst case an attacker can use it for randomness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants