Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix server side judge (close #4787) #4788

Merged
merged 2 commits into from
Jul 22, 2021
Merged

fix: fix server side judge (close #4787) #4788

merged 2 commits into from
Jul 22, 2021

Conversation

zhangyuang
Copy link
Contributor

Mock window object is very frequent in server side rendering, the isNode judge is inaccurate。
Maybe we should judge further

@zhangyuang
Copy link
Contributor Author

@vltansky please see see

@nolimits4web
Copy link
Owner

I would say checking window.screen is not right as it has nothing to do with the logic, I think better to check what we really need is window.HTMLElement

@zhangyuang
Copy link
Contributor Author

zhangyuang commented Jul 22, 2021

fine, has been modified, now it's use window.HTMLElement for condition @nolimits4web

@nolimits4web nolimits4web merged commit ca4f6b8 into nolimits4web:master Jul 22, 2021
@nolimits4web
Copy link
Owner

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants