Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using cloneNode in sliders without loops in SolidJS #5860

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Stop using cloneNode in sliders without loops in SolidJS #5860

merged 1 commit into from
Jul 8, 2022

Conversation

TiagoCavalcante
Copy link
Contributor

This allows events to be assigned to the slides as usually

Before it didn't work:

<Swiper>
  <SwiperSlide>
    <button onClick={() => window.alert("clicked")}>
      Click me!
    </button>
  </SwiperSlide>
</Swiper>

Now it works

@TiagoCavalcante
Stop using cloneNode in sliders without loops in SolidJS
30bfb54 
This allows events be assigned to the slides as usually
@nolimits4web nolimits4web merged commit d14c432 into nolimits4web:master Jul 8, 2022
@nolimits4web
Copy link
Owner

Merged, thanks!

@TiagoCavalcante TiagoCavalcante deleted the reduce-cloning branch July 8, 2022 18:30
@TiagoCavalcante TiagoCavalcante mentioned this pull request Jul 9, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Aug 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TiagoCavalcante @nolimits4web