Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch for very large sliders using virtual slides #6533

Merged
merged 5 commits into from
Apr 14, 2023

Conversation

dylan1951
Copy link
Contributor

Rudimentary patch for issue #6530

Patched it enough for my purposes but unlikely to be best practices and won't cover all usages. I'm new to web dev and open source so feedback is welcome.

@nolimits4web
Copy link
Owner

nolimits4web commented Mar 30, 2023

Hi! Thanks! I think this line:

const adjustment = Math.trunc(swiper.translate / swiper.support.maxPx) * swiper.support.maxPx;

should be a swiper instance method as it is the same everywhere

plus maxPx shouldn't be a part of support, it is just a constant which should be inside of that adjustment calc method

@dylan1951
Copy link
Contributor Author

OK thanks I put it into a swiper method, also tested with RTL and vertical direction.

@nolimits4web nolimits4web merged commit e48daa5 into nolimits4web:master Apr 14, 2023
@nolimits4web
Copy link
Owner

Merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants