Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

focusable-elements cannot be set as a string prop, since it is defined as a boolean #4822

Closed
5 of 6 tasks
lsblsb opened this issue Aug 12, 2021 · 0 comments
Closed
5 of 6 tasks
Labels

Comments

@lsblsb
Copy link

lsblsb commented Aug 12, 2021

Check that this is really a bug

  • I confirm

Reproduction link

https://codesandbox.io/s/swiper-vue-default-forked-ewdkh?file=/src/App.vue

Bug description

The documentation (https://swiperjs.com/swiper-api) states:

focusableElements string 'input, select, option, textarea, button, video, label' CSS selector for focusable elements. Swiping will be disabled on such elements if they are "focused"

But the relating vue prop focusable-elements is defined as a boolean.

Expected Behavior

If i set focusableElements via the focusable-elements prop, i expect that the focusable elements are set as a string, like stated in the docs.

Actual Behavior

[Vue warn]: Invalid prop: type check failed for prop "focusableElements". Expected Boolean, got String with value ".focusable". at [...]

Swiper version

swiper 6.7.5 @ vue 3.0.0

Platform/Target and Browser Versions

Ubuntu 20.04

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant