Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow: clip does not work well on Firefox #7017

Closed
5 of 6 tasks
mateuswetah opened this issue Sep 6, 2023 · 3 comments
Closed
5 of 6 tasks

Overflow: clip does not work well on Firefox #7017

mateuswetah opened this issue Sep 6, 2023 · 3 comments

Comments

@mateuswetah
Copy link

Check that this is really a bug

  • I confirm

Reproduction link

https://codesandbox.io/s/agitated-moon-tjg9tt?fontsize=14&hidenavigation=1&theme=dark

Bug description

As discussed here:
#6738 (comment)

The recently introduced overflow: clip instead of overflow: hidden in the .swiper-wrapper class has introduced some issues. When using a carousel inside a flex container, the overflow hidden worked equally in any browser. Now, in Firefox, the Carousel ends up expanding more than it should.

Expected Behavior

The linked provided for reproduction offers a comparison of the strategies:
https://codesandbox.io/s/agitated-moon-tjg9tt?fontsize=14&hidenavigation=1&theme=dark&file=/src/index.js

Both carousels should be equal.

Actual Behavior

This screnshot shows how things are in Firefox on the linked provided for reproduction:
https://user-images.githubusercontent.com/1184874/264720125-3fe75889-d0a7-4efd-bdcd-3df12cac8606.png

Swiper version

10.0.0

Platform/Target and Browser Versions

Linux Ubuntu 20.04, Firefox 117

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
@nolimits4web
Copy link
Owner

But that is a Firefox bug, not with Swiper. You should open an issue there. In Swiper 11 default overflow will be back to the "hidden"

@mateuswetah
Copy link
Author

Wait, but why will it be back? Would you have a release date planned?

I considered that it might be specific to Firefox, but I'm not sure if it is some kind of CSS specification interpretation that may be "correct" on Firefox and misunderstood on Chrome...

@nolimits4web
Copy link
Owner

Wait, but why will it be back? Would you have a release date planned?

I considered that it might be specific to Firefox, but I'm not sure if it is some kind of CSS specification interpretation that may be "correct" on Firefox and misunderstood on Chrome...

Because it produces more issues and problems than goodies :) Seems to be not many know how it works and what is it for. And if anyone needs "clip", it can be easily set with one line of custom CSS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants