Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current line number's color is not highlighted #116

Closed
huyvohcmc opened this issue Apr 13, 2018 · 2 comments
Closed

Current line number's color is not highlighted #116

huyvohcmc opened this issue Apr 13, 2018 · 2 comments

Comments

@huyvohcmc
Copy link

huyvohcmc commented Apr 13, 2018

In neovim with iterm2 version 3.1.5, when termguicolors is turned on tthe color of the current line number is not white like when it is being turned off. Is it an expected behavior? If not, then how can we fix it?

neovim with set termguicolors turned on:
screen shot 2018-04-27 at 5 07 26 pm

neovim with set termguicolors turned off:
screen shot 2018-04-27 at 5 06 31 pm

@dylnmc
Copy link
Contributor

dylnmc commented May 31, 2018

I agree. This is annoying me at work. Will fix when I get home.

Either both dark or white (my personal pref since current line number is often important).


quickfix:

augroup Nord
    autocmd!
    autocmd ColorScheme nord highlight CursorLineNr guifg=#E5E9F0 ctermfg=7
augroup end

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Jun 23, 2018

Superseded by 50ec737 in #100

Thanks for your contribution 👍

Sorry for the delay, I've had no free time (job 👨‍⚕️, study 📖, life 🏋️‍♂️ etc.) to work on my or any other :octocat: OSS project (see Tweets 🐦 from April and June), but from the beginning of July I finished my studies and can finally spend time on OSS again 💚

I've merged #100 some minutes ago which includes a fix for this problem, but haven't read this issue yet, otherwise I would have created a separate branch for it.

The commit that fixes the problem is 50ec737.

Before

After

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants