Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use odometry estimate on ICP convergence error #7

Open
boxanm opened this issue Oct 14, 2022 · 1 comment
Open

Use odometry estimate on ICP convergence error #7

boxanm opened this issue Oct 14, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@boxanm
Copy link
Contributor

boxanm commented Oct 14, 2022

Norlab_icp_mapper currently throws an error when the ICP doesn't converge to a valid solution. Subsequently, this package catches the error, saves the current map and exits. Although legitimate during offline mapping sessions, this approach is not very practical in real-life mapping applications. It is therefore currently overcome by setting the limits for the convergence error to very high values. Here's an example from Warthog's config file:

  - BoundTransformationChecker:
      maxRotationNorm: 1000000.1
      maxTranslationNorm: 15000.00

Instead, this package could catch the error, log it and use the odometry estimate without the ICP correction. Furthermore, users could use a parameter defining the strictness of the convergence error handling.

@boxanm boxanm added the enhancement New feature or request label Oct 14, 2022
@simonpierredeschenes
Copy link
Collaborator

The reason why the warthog config is set to these high values is because of some other bug we had when loading the initial map in the teach and repeat node. I understand what you mean, but I think that it is fine if this exception causes the mapping to crash. It means that there are problems that need to be addressed in the ICP config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants