Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use before_action instead of before_filter #37

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use before_action instead of before_filter #37

wants to merge 3 commits into from

Conversation

anilmaurya
Copy link

Rails 5 do not support before_filter therefore changed before_filter to before_action

@johnnyshields
Copy link
Collaborator

please use respond_to?(:before_filter) ? ... to make it Rails version agnostic

@anilmaurya
Copy link
Author

@johnnyshields Updated pull request

@bakedbean
Copy link

is there a reason this never got merged? I just had to fork to make the same change, seems like a worthwhile thing to get into master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tboerger tboerger tboerger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anilmaurya @johnnyshields @bakedbean @tboerger