Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N-API port #54

Open
gabrielschulhof opened this issue Feb 5, 2019 · 2 comments
Open

N-API port #54

gabrielschulhof opened this issue Feb 5, 2019 · 2 comments
Assignees

Comments

@gabrielschulhof
Copy link

Would it be possible to port this module to N-API? N-API is available for Node.js versions 4-master via https://github.com/nodejs/node-addon-api. Porting to N-API would relieve the burden of having to rebuild the module for every Node.js major release, because an addon built with node-addon-api will work with the version of Node.js against which it was compiled as well as all future versions of Node.js without recompilation. The syntax of node-addon-api is very similar to NAN which should make porting easy.

@stephenwvickers
Copy link
Collaborator

Hi @gabrielschulhof

Yes, I would be willing to do this, I've been waiting for the N-API to become stable and proven, and it looks like now is the time.

The N-API looks fairly easy to use, but do you have any reference examples that would help someone get started?

Thanks

Steve

@theboolean
Copy link

Hi @stephenwvickers, thank you for this module! Did you take a look at #75? Is there something else to do before merging it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants