Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the output message of notation inspect images without signatures #624

Closed
yizha1 opened this issue Apr 10, 2023 · 1 comment · Fixed by #666
Closed

Improve the output message of notation inspect images without signatures #624

yizha1 opened this issue Apr 10, 2023 · 1 comment · Fixed by #666
Assignees
Labels
bug Something isn't working UX User experience changes
Milestone

Comments

@yizha1
Copy link
Contributor

yizha1 commented Apr 10, 2023

What is the areas you experience the issue in?

Notation CLI

What is not working as expected?

Use notation inspect images without any signatures, the output message is not user friendly.

notation inspect localhost:5000/nginx:latest
Warning: Always inspect the artifact using digest(@sha256:...) rather than a tag(:latest) because resolved digest may not point to the same signed artifact, as tags are mutable.
Inspecting all signatures for signed artifact
localhost:5000/nginx@sha256:bfb112db4075460ec042ce13e0b9c3ebd982f93ae0be155496d050bb70006750
└── application/vnd.cncf.notary.signature

What did you expect to happen?

The output message should tell the users that there are no signatures associated with the image.

How can we reproduce it?

Run notation inspect against images without any signatures.

Describe your environment

WSL

What is the version of your Notation CLI or Notation Library?

v1.0.0-rc.3

@yizha1 yizha1 added bug Something isn't working triage Need to triage UX User experience changes labels Apr 10, 2023
@yizha1 yizha1 removed the triage Need to triage label Apr 26, 2023
@yizha1 yizha1 added this to the 1.0.0 milestone Apr 26, 2023
@yizha1
Copy link
Contributor Author

yizha1 commented Apr 26, 2023

Improve the output when inspecting images without signatures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UX User experience changes
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants