Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CVE-2019-20056: assert in stbi__shiftsigned #886

Closed
mmuehlenhoff opened this issue Jan 22, 2020 · 2 comments
Closed

CVE-2019-20056: assert in stbi__shiftsigned #886

mmuehlenhoff opened this issue Jan 22, 2020 · 2 comments
Labels
1 stb_image 2 bug

Comments

@mmuehlenhoff
Copy link

This was originally reported for libsixel which embeds a copy of libstb, see saitoha/libsixel#126

The patch applied by the libsixel developer is:
saitoha/libsixel@bab1e60
@rygorous
Copy link
Collaborator

That fix (specifically the if (v >= 0 && v < 256) return (0);) looks incorrect to me.

@rygorous rygorous added the 2 bug label Jun 29, 2021
@rygorous
Copy link
Collaborator

rygorous commented Jul 3, 2021

Actually this was already fixed as part of bfaccab which is part of the released version 2.26.

@rygorous rygorous closed this as completed Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 stb_image 2 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rygorous @nothings @mmuehlenhoff