Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Issue with 1.7 #90

Closed
notnil opened this issue Dec 18, 2021 · 1 comment · Fixed by #91
Closed

Parse Issue with 1.7 #90

notnil opened this issue Dec 18, 2021 · 1 comment · Fixed by #91
Labels

Comments

@notnil
Copy link
Owner

notnil commented Dec 18, 2021

@sumnerevans I found a parsing issue with the latest regex code. It can't parse the following pgn:

[Event "Rated Blitz game"]
[Site "https://lichess.org/JXpwpOJf"]
[White "georgekontos"]
[Black "zev105"]
[Result "1-0"]
[UTCDate "2014.08.31"]
[UTCTime "22:03:44"]
[WhiteElo "1292"]
[BlackElo "1429"]
[WhiteRatingDiff "+15"]
[BlackRatingDiff "-15"]
[ECO "C42"]
[Opening "Russian Game: Three Knights Game"]
[TimeControl "300+3"]
[Termination "Normal"]

1. e4 e5 2. Nf3 Nf6 3. Nc3 Bc5 4. Nxe5 Qe7 5. Bd3 Qxe5 6. O-O O-O 7. a3 d6 8. b4 Bd4 9. Bb2 Nbd7 10. Bc4 Nb6 11. Qe2 Nxc4 12. Qxc4 Be6 13. Qxc7 Nxe4 14. Nxe4 Bxb2 15. Rae1 Rac8 16. Qxd6 Bc4 17. Qxe5 Bxe5 18. d3 Be6 19. Nc5 Bxh2+ 20. Kxh2 Bd5 21. c4 Bc6 22. Re7 Rcd8 23. Rd1 b6 24. b5 Bxb5 25. cxb5 bxc5 26. Rxa7 Rd6 27. Rc7 Rh6+ 28. Kg1 Re8 29. Rxc5 f5 30. b6 f4 31. b7 Rb8 32. Rc8+ Rxc8 33. bxc8=Q+ Kf7 34. Qf5+ Rf6 35. Qxh7 f3 36. g3 Ra6 37. Qh5+ g6 38. Qh7+ Kf6 39. Qh8+ Kg5 40. Re1 Rxa3 41. Re5+ Kg4 42. Qh4# 1-0

I'm having trouble reasoning about the long regex. Any way you can take a look?

@notnil notnil added the bug label Dec 18, 2021
@sumnerevans
Copy link
Contributor

Sorry about the long regex... Is there some way to make a regex that is multiline with comments like this from python? https://stackoverflow.com/questions/20668996/commenting-regular-expressions-in-python#20669086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants