Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate and key paths cannot have spaces in them #1859

Open
fabianhartmann2 opened this issue May 16, 2024 · 1 comment
Open

Certificate and key paths cannot have spaces in them #1859

fabianhartmann2 opened this issue May 16, 2024 · 1 comment
Labels

Comments

@fabianhartmann2
Copy link

Describe the bug
As soon as I use the --cert --key as arguments and the path to the cert contains spaces, I get the following error.

/Library/websockify/websockify/websocket.py:31: UserWarning: no 'numpy' module, HyBi protocol will be slower
warnings.warn("no 'numpy' module, HyBi protocol will be slower")
Usage:
main.py [options] [source_addr:]source_port target_addr:target_port
main.py [options] --token-plugin=CLASS [source_addr:]source_port
main.py [options] --unix-target=FILE [source_addr:]source_port
main.py [options] [source_addr:]source_port -- WRAP_COMMAND_LINE

main.py: error: Error parsing listen port

Failed to start WebSockets proxy

To Reproduce
Steps to reproduce the behavior:

  1. Generate a self-signed cert and store it in a path with spaces.
  2. start novnc_proxy

Expected behavior
websockify should launch and noVNC accessible.

Screenshots
If applicable, add screenshots to help explain your problem.

Client (please complete the following information):

  • OS: macOS 15.4
  • Browser: Safari, Microsoft Edge
  • Browser version: n/a

Server (please complete the following information):

  • noVNC version: latest
  • VNC server: macOS built in
  • WebSocket proxy: websockify

Additional context
Solution
Changing line 195 of novnc_proxy to the following, solves the issue: ${WEBSOCKIFY} ${SYSLOG_ARG} ${SSLONLY} ${FILEONLY_ARG} --web "${WEB}" ${CERT:+--cert "${CERT}"} ${KEY:+--key "${KEY}"} ${PORT} ${VNC_DEST} ${HEARTBEAT_ARG} ${IDLETIMEOUT_ARG} ${RECORD_ARG} ${TIMEOUT_ARG} ${WEBAUTH_ARG} ${AUTHPLUGIN_ARG} ${AUTHSOURCE_ARG} &

@CendioOssman
Copy link
Member

This should be fixed by #1741, but unfortunately that PR has stalled. :/

@samhed samhed linked a pull request May 17, 2024 that will close this issue
@CendioOssman CendioOssman changed the title Failed to start WebSockets proxy Certificate and key paths cannot have spaces in them Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants