feat: additional config parameter asg_delete_timeout to configure the… #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 for your contribution, will check asap |
npalm
requested changes
Feb 23, 2021
|
Thanks for the contribution, just one request, see review |
… timeout when trying to delete the ASG
sure, should be done :-) |
npalm
approved these changes
Feb 24, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Feb 28, 2021
## [4.23.0](4.22.0...4.23.0) (2021-02-28) ### Features * additional config parameter asg_delete_timeout to configure the timeout when trying to delete the ASG ([#305](#305)) ([f60c9d5](f60c9d5)) * allow multilines build scripts ([#282](#282)) ([7000c07](7000c07)), closes [#250](#250) ### Bug Fixes * autoscaling configuraton ([#301](#301)) ([6b35a10](6b35a10)) * respect create_cache_bucket variable and avoid concurrent changes to cache bucket ([#296](#296)) ([c3629f6](c3629f6))
|
🎉 This PR is included in version 4.23.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To gracefully shutdown the GitLab runner, the deletion of the corresponding AutoScalingGroup might take more than the default timeout of 10 minutes.
Therefore, I added another config parameter to be able to increase the value accordingly.
Migrations required
NO - default value matches to the Terraform default value
Verification
Tested in my local environment.
Documentation
I added the new config parameter to the README.