[Proposal] Use better ressources names #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semantic-releaser bot
pushed a commit
that referenced
this pull request
Aug 28, 2021
## [4.29.0](4.28.0...4.29.0) (2021-08-28) ### Features * Allow configuring docker machine egress rules, see PR [#351](#351) for upgrade instructions ([845e018](845e018)) * Parametrize runner instance launch configuration metadata options ([#348](#348)) ([a4406dc](a4406dc)) * replace launch configuration with launch template ([#337](#337)) ([b805fb6](b805fb6)) * support for settings Sentry DSN ([#352](#352)) ([2a07466](2a07466)) ### Bug Fixes * Use better ressources names ([#356](#356)) ([817e040](817e040))
|
🎉 This PR is included in version 4.29.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
npalm
pushed a commit
that referenced
this pull request
Oct 4, 2021
## [4.29.0](4.28.0...4.29.0) (2021-08-28) ### Features * Allow configuring docker machine egress rules, see PR [#351](#351) for upgrade instructions ([845e018](845e018)) * Parametrize runner instance launch configuration metadata options ([#348](#348)) ([a4406dc](a4406dc)) * replace launch configuration with launch template ([#337](#337)) ([b805fb6](b805fb6)) * support for settings Sentry DSN ([#352](#352)) ([2a07466](2a07466)) ### Bug Fixes * Use better ressources names ([#356](#356)) ([817e040](817e040))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Launch template is named based on
runners_namevariable. It seems to be an error because this launch template is used to deploy the agent runner not docker machines. Tell me if i'm wrong.Moreover security groups have tag
Namewithlocal.name_sgbut thename_prefixdo not use this local. Maybe it is an oversight ?Migrations required
NO, default values not change
Verification
Minor changes