feat: allow setting runners.docker.services #491
Conversation
jonmcewen
changed the title
|
@jonmcewen just did a large update on develop, the module is now bumped to AWS provider 4.x. Please can you rebase your PR? Sorry for the inconvience. |
|
close: #489 |
There was a problem hiding this comment.
@jonmcewen change looks good to me. Not tested yet. Small remark.
jonmcewen
force-pushed
the
489-allow-setting-runners-docker-services
branch
from
7568d72
to
f1d5f68
Compare
|
@npalm is there more work needed on this, or can it be merged? Thanks |
|
Sorry had holiday last week's. Will check PRs asap |
Me too :-) |
|
Conflict resolved |
|
@npalm please could you review and merge? |
|
PR has status "Changes Requested" but I think I have already addressed all comments |
|
@npalm if you have any time, please could you have another look at this PR? Is there more I need to do for this to be merged? I took your "Need to test" as you needing to test it (I already did, of course). Many thanks |
Thanks will check asap |
|
@cinacio @kayman-mk @baolsen I'm looking for a new reviewer for this PR please. I'd really like to get this merged. Many thanks, Jon |
|
Job output from your test looks good to me. I suppose that you rebased your branch on the current development branch? |
@kayman-mk I did rebase, but it was some time ago. Do I need to rebase again? Are you able to remove @npalm as a pending reviewer, or does the PR need more than one approval? |
|
Branch is almost up to date. Just some pending doc changes. Let me quickly test it. |
|
Succeeded. I did not activate your new feature and the pipeline is still running. |
|
There is still a "changes requested", but I can't see what it is for. How do we clear that? |
|
Is this now to be superseded by #511? |
|
@npalm Could you check this one please? PR indicates "changes requested" but we can't find any. I tested the PR a week ago and it looked good, at least without using the new feature. |
|
Many thanks @kayman-mk @npalm |
Description
Enable configuration of docker mirror via a service defined in config.toml
See https://gitlab.com/gitlab-org/gitlab-runner/-/issues/27171 and https://docs.gitlab.com/ee/ci/docker/using_docker_build.html#the-service-in-the-gitlab-runner-configuration-file
Migrations required
NO
Verification
Default example updated to demonstrate feature. Tested with this CI job: https://gitlab.com/jonmcewen1/yet-another-spring/-/jobs/2484859847
Documentation
We use pre-commit to update the Terraform inputs and outputs in the documentation via terraform-docs. Ensure you have installed those components.