feat: do not add a the Name tag for docker+machine >= 0.16.2

[kayman-mk]

Description

This PR checks the version of the docker machine and adds the Name tag if it is not done by the driver itself. It also removes the second Name tag from the amazonec2-tags in the config.toml. In consequence it is no longer possible to change the Name of the Runners as the Name tag is now added by the docker-machine driver (for versions >= 0.16.2).

docker_machine_version >= 0.16.2 automatically adds the Name tag to the EC2 instances. Adding another Name tag here causes the EC2 creation process to fail.

To be able to configure the name, var.overrides["name_docker_machine_runners"] is added as prefix to the name of the docker machine which is used as name for the EC2 instance by the driver.

The main logic was taken from hashicorp/terraform#22688 (comment)

Closes #521

Migrations required

No.

Verification

• Verify the version logic manually with a local.tf only. Returns true if version >= 0.16.2
• Check the config.toml for versions >= 0.16.2 with overrides["name_docker_machine_runners"]. No Name tag present.
• Check the config.toml for versions >= 0.16.2 without overrides["name_docker_machine_runners"]. No Name tag present.
• Check the config.toml for versions < 0.16.2 with overrides["name_docker_machine_runners"]. No Name tag equals the name set in the override.
• Check the config.toml for versions < 0.16.2 without overrides["name_docker_machine_runners"]. Name tag shows var.environment + "-docker-machine"
• Replace the current module with this version and check if tags are changed (using version < 0.16.2). There shouldn't be any change in the resource tags.

[kayman-mk]

Also see #521 for long-wan-ep's test.

[kayman-mk]

Still discussing the MachineName option in #521

[kayman-mk]

Using the var.overrides["name_docker_machine_runners"] as prefix for the docker machine name. There is no change if docker machine < 0.16.2 is used (these versions use the Name tag provided), but since 0.16.2 the prefix will show up in the name of the EC2 instance (name of docker machine = name of EC2 instance).

[long-wan-ep]

Tested out the prefix for the machine name, it looks good to me. One thing to note is that gitlab-runners will add runner-<SHORT_TOKEN> as a prefix to the machine name so the name of the instance will end up being runner-<SHORT_TOKEN>-<NAME_OVERRIDE>-<MACHINE_IDENTIFIER>, but I think it's ok.

[npalm]

LGTM, tested with default example

[semantic-releaser]

🎉 This PR is included in version 5.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀