fix: add var.environment to the name of the S3 cache bucket
#533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npalm
reviewed
Oct 10, 2022
npalm
added a commit
that referenced
this pull request
Oct 13, 2022
* add `var.environment` to name of cache bucket * shorten the hostname if no override is used Co-authored-by: kayma <[email protected]>
npalm
pushed a commit
to npalm/test-repo
that referenced
this pull request
Dec 8, 2022
### [5.4.1](cattle-ops/terraform-aws-gitlab-runner@5.4.0...5.4.1) (2022-10-13) ### Bug Fixes * Add var.environment to the name of the S3 cache bucket [#533](cattle-ops/terraform-aws-gitlab-runner#533) ([#555](cattle-ops/terraform-aws-gitlab-runner#555)) ([6e0cd97](cattle-ops/terraform-aws-gitlab-runner@6e0cd97))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the name of the environment to the S3 cache bucket name. As #507 explains, the environment name from
var.environmentis not part of the S3 cache bucket name which can cause problems if the module is deployed multiple times.Furthermore the documentation states that
var.environmentis used as prefix for the resources which was not the case here.Closes #507
Migrations required
No, but the whole cache bucket is lost and you may experience degraded performance of your runners for a while as the cache is cleared.
Verification