Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Add "max-len": ["error", 80] to .eslintrc.json and make it work #2029 #2361

Closed
wants to merge 0 commits into from
Closed

[BUG] Add "max-len": ["error", 80] to .eslintrc.json and make it work #2029 #2361

wants to merge 0 commits into from

Conversation

Edu93Jer
Copy link
Contributor

@Edu93Jer Edu93Jer commented Dec 16, 2020 •
edited
Loading

fix : Add max-len to the .eslintrc with the proper configs so the maximum length of each line be 80 characters

Updated the eslint rules (.eslintrc.json)

References

Fixes #2029

@Edu93Jer Edu93Jer requested a review from a team as a code owner December 16, 2020 00:29
@isaacs
Copy link
Contributor

isaacs commented Dec 16, 2020

The missing piece here is to also update the code so that it passes the new lint rule ;)

If you run npm run lint, you'll see what I mean. https://github.com/npm/cli/pull/2361/checks?check_run_id=1560773087#step:5:260

@Edu93Jer
Copy link
Contributor Author

Just updated the line breaks, so it passes the new lint rule.

@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release 💎 Free Internet Points 💎 similar to "Good First issue" - although more impactful labels Dec 16, 2020
@isaacs isaacs changed the base branch from latest to release/v7.3.0 December 18, 2020 19:36
isaacs pushed a commit that referenced this pull request Dec 18, 2020
@Edu93Jer @isaacs
Add max-len to lint rules
a92d310 
PR-URL: #2361
Credit: @Edu93Jer
Close: #2361
Reviewed-by: @isaacs

EDIT(@isaacs): amended to match some of the fixes to our current style
conventions
@isaacs isaacs closed this Dec 18, 2020
@ruyadorno ruyadorno mentioned this pull request Dec 18, 2020
Closed
@a2br a2br mentioned this pull request Dec 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
💎 Free Internet Points 💎 similar to "Good First issue" - although more impactful release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Add "max-len": ["error", 80] to .eslintrc.json and make it work
4 participants
@Edu93Jer @isaacs @ruyadorno @darcyclarke