Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw an error when trying to dedupe in global mode #2716

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Feb 17, 2021

as described in #2620 it doesn't make much sense to globally dedupe, and clearly the wrong thing happens. let's just fail immediately instead of potentially breaking global packages.

References

Closes #2620

@nlf nlf requested a review from a team as a code owner February 17, 2021 21:39
Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be awesome to backport this into npm 6, in the event another patch release goes out

@darcyclarke darcyclarke added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Feb 18, 2021
@nlf nlf changed the base branch from latest to release/v7.5.5 February 18, 2021 20:53
@nlf nlf merged commit 69e0c4e into release/v7.5.5 Feb 18, 2021
@nlf nlf mentioned this pull request Feb 22, 2021
@nlf nlf deleted the nlf/no-global-dedupe branch March 28, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] npm dedupe -g removes some globally installed packages
4 participants