Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): add missing note #3699

Merged
merged 1 commit into from
Sep 30, 2021
Merged

fix(docs): add missing note #3699

merged 1 commit into from
Sep 30, 2021

Conversation

behnammodi
Copy link
Contributor

Added missing note

@behnammodi behnammodi requested a review from a team as a code owner August 31, 2021 05:26
@behnammodi behnammodi changed the title fix(docs): add missing notice fix(docs): add missing note Aug 31, 2021
@darcyclarke darcyclarke added semver:patch semver patch level for changes Release 7.x work is associated with a specific npm 7 release labels Aug 31, 2021
@wraithgar
Copy link
Member

Can this be reworded a little? It's not clear what is being communicated by the addition? Perhaps something like "commands will be run in each workspace in the order they appear in your package.json"?

@behnammodi
Copy link
Contributor Author

@wraithgar Sure

lukekarrys
lukekarrys suggested changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@lukekarrys lukekarrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @wraithgar's comment that this should be reworded a little.

@behnammodi
Copy link
Contributor Author

@wraithgar @lukekarrys Done

@wraithgar wraithgar changed the base branch from latest to release-next September 29, 2021 21:56
@wraithgar
Copy link
Member

@behnammodi can you resolve the conflicts this has against release-next? I know the default branch in npm is latest but the release-next branch is the one you want to branch off of for PRs.

@wraithgar
Copy link
Member

Sorry about that, this file usually doesn't get a lot of activity but it just so happened to get conflicting updates in the last two weeks.

@behnammodi
Copy link
Contributor Author

@wraithgar no problem, sure, I'll do it

@behnammodi
Copy link
Contributor Author

@wraithgar Done

@wraithgar wraithgar merged commit bb0b2da into npm:release-next Sep 30, 2021
This was referenced Sep 30, 2021
Closed
Merged
@npm-robot npm-robot mentioned this pull request Oct 4, 2021
Closed
Bugger1980
Bugger1980 reviewed Jan 9, 2023
View reviewed changes
Copy link

@Bugger1980 Bugger1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logs_935.zip

@Bugger1980
Copy link

Bugger1980 commented Jan 9, 2023 •
edited
Loading

=0&at=2ahUKEwjp.txt

logs_935.zip

@Bugger1980 Bugger1980 mentioned this pull request Jan 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bugger1980 Bugger1980 Bugger1980 left review comments

@lukekarrys lukekarrys lukekarrys approved these changes

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@behnammodi @wraithgar @Bugger1980 @lukekarrys @darcyclarke