[BUG] npm undeprecate still not working

[globules-io]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

npm ERR! code E400
npm ERR! 400 Bad Request - PUT https://registry.npmjs.org/@globules-io%2fogx.js - deprecations must be strings

28 verbose stack HttpErrorGeneral: 400 Bad Request - PUT https://registry.npmjs.org/@globules-io%2fogx.js - deprecations must be strings

Expected Behavior

undeprecate a package

Steps To Reproduce

npm deprecate @globules-io/[email protected] ""

Environment

• OS: Windows 10 x64
• Node: 16.10.0
• npm: 7.24.2

[sandersn]

I'm not sure I have exactly the same problem, but I temporarily edited deprecate.js to remove the msg check at the start of deprecate:

async deprecate([pkg, msg]) {
  if (!pkg) //    <---- this used to read `if (!pkg || !msg)`

But this means if you forget the message it will always undeprecate, which doesn't seem right. The correct fix is probably to have a separate flag or a special message that causes undeprecation, since "" is ambiguous with not passing the flag at all, apparently.

[globules-io]

I totally agree, undeprecate should be its own command, or maybe even something more eloquant such as restore

[wraithgar]

This appears to have been fixed since this issue was created. There was a PR that fixed the regression here: #3484.

I was able to deprecate and un-deprecate two test packages, one with only one version and one with multiple versions.

undeprecate would be a handy command to have, and that is in our backlog of things to do.