Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't try to open file:/// urls #4025

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Conversation

wraithgar
Copy link
Member

These are never valid in the contexts from which this lib is called.
Namely these are the bugs, docs, fund, help, and repo commands, and for
oauth logins.

@wraithgar wraithgar requested a review from a team as a code owner November 9, 2021 22:35
@isaacs
Copy link
Contributor

isaacs commented Nov 9, 2021

Yeah, I honestly don't even know what it would mean to have a file: url in any of these fields, and have no idea why that was ever supported. Hearty +1.

These are never valid in the contexts from which this lib is called.
Namely these are the bugs, docs, fund, help, and repo commands, and for
oauth logins.

PR-URL: #4025
Credit: @wraithgar
Close: #4025
Reviewed-by: @isaacs
@wraithgar wraithgar merged commit 7887fb3 into release-next Nov 9, 2021
@wraithgar wraithgar deleted the gar/open-file-url branch November 9, 2021 23:08
@wraithgar
Copy link
Member Author

wraithgar commented Nov 9, 2021

This temporarily breaks npm help with no browser. A PR to fix it is here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants