From ae91a1e5729c9e1cafa45e6ddbc183990c687ea1 Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Mon, 18 Feb 2019 22:56:49 -0800 Subject: [PATCH 1/2] Update `knownBroken` version As I've documented [here](https://github.com/creationix/nvm/blob/master/nvm.sh#L237) in `nvm install-latest-npm`, the last version of `npm` that works on node < v6 is npm v5 - npm v6+ requires node 6. --- lib/utils/unsupported.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/utils/unsupported.js b/lib/utils/unsupported.js index bfed5cdbea634..20cee157ee403 100644 --- a/lib/utils/unsupported.js +++ b/lib/utils/unsupported.js @@ -8,7 +8,7 @@ var supportedNode = [ {ver: '11', min: '11.0.0'}, {ver: '12', min: '12.0.0'} ] -var knownBroken = '<4.7.0' +var knownBroken = '<6.0.0' var checkVersion = exports.checkVersion = function (version) { var versionNoPrerelease = version.replace(/-.*$/, '') From 9a3b555fc78677e58a17317b1f3d175dde87a970 Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Mon, 18 Feb 2019 23:37:02 -0800 Subject: [PATCH 2/2] fixup: update tests --- test/tap/unsupported.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/tap/unsupported.js b/test/tap/unsupported.js index 7abc8da741441..deae8d3c034c1 100644 --- a/test/tap/unsupported.js +++ b/test/tap/unsupported.js @@ -21,8 +21,8 @@ var versions = [ ['v2.3.1', true, true], ['v3.0.0', true, true], ['v4.5.0', true, true], - ['v4.8.4', false, true], - ['v5.7.1', false, true], + ['v4.8.4', true, true], + ['v5.7.1', true, true], ['v6.8.1', false, false], ['v7.0.0-beta23', false, true], ['v7.2.3', false, true],