From 8bfaed10aa4fea2769f1c02ccd1dfeec1c3e37e3 Mon Sep 17 00:00:00 2001 From: Jason Etcovitch Date: Tue, 29 Oct 2019 13:35:08 -0400 Subject: [PATCH 1/7] Add ci.yml --- .github/workflows/ci.yml | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 .github/workflows/ci.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 0000000000000..6ae7b64fd493c --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,37 @@ +name: Node CI + +on: [push] + +jobs: + build: + strategy: + matrix: + node-version: [8.x, 10.x, 12.x] + os: [ubuntu-latest, windows-latest] + + runs-on: ${{ matrix.os }} + + steps: + # Checkout the npm/cli repo + - uses: actions/checkout@v1 + + # Installs the specific version of Node.js + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v1 + with: + node-version: ${{ matrix.node-version }} + + # Run the installer script + - run: node . install + + # Run the tests + - run: node . run tap -- \"test/tap/*.js\" -t600 -Rclassic -c + env: + DEPLOY_VERSION: testing + COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_OPTIONAL_TOKEN }} + + # Run the linter + - run: npx standard + + # Validate licenses + - run: node . run licenses From 4ac2170a3b460873121834bd11fffb4a4bea955c Mon Sep 17 00:00:00 2001 From: Jason Etcovitch Date: Tue, 29 Oct 2019 13:41:19 -0400 Subject: [PATCH 2/7] Remove escapes, add sudo tests for Linux --- .github/workflows/ci.yml | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6ae7b64fd493c..0cfe946c0a072 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,17 +21,23 @@ jobs: with: node-version: ${{ matrix.node-version }} + - name: Run sudo tests on Linux + if: ${{ matrix.os }} === ubuntu-latest + run: sudo PATH=$PATH $(which node) . run tap -- \"test/tap/*.js\" --coverage --timeout 600 + # Run the installer script - - run: node . install + - name: Install dependencies + run: node . install # Run the tests - - run: node . run tap -- \"test/tap/*.js\" -t600 -Rclassic -c + - name: Run Tap tests + run: node . run tap -- "test/tap/*.js" -t600 -Rclassic -c env: DEPLOY_VERSION: testing COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_OPTIONAL_TOKEN }} - # Run the linter - - run: npx standard + - name: Lint + run: npx standard - # Validate licenses - - run: node . run licenses + - name: Validate licenses + run: node . run licenses From 38bc5755037a0480e47dc5fbc66af3bde1e80b0a Mon Sep 17 00:00:00 2001 From: Jason Etcovitch Date: Tue, 29 Oct 2019 13:42:46 -0400 Subject: [PATCH 3/7] Change if syntax --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0cfe946c0a072..68fd7705eb76d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,8 +22,8 @@ jobs: node-version: ${{ matrix.node-version }} - name: Run sudo tests on Linux - if: ${{ matrix.os }} === ubuntu-latest - run: sudo PATH=$PATH $(which node) . run tap -- \"test/tap/*.js\" --coverage --timeout 600 + if: matrix.os === "ubuntu-latest" + run: sudo PATH=$PATH $(which node) . run tap -- "test/tap/*.js" --coverage --timeout 600 # Run the installer script - name: Install dependencies From 4a57fcabdc235ffb785ef98ce4415dcbeba1b8ab Mon Sep 17 00:00:00 2001 From: Jason Etcovitch Date: Tue, 29 Oct 2019 13:44:17 -0400 Subject: [PATCH 4/7] Third times the charm --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 68fd7705eb76d..fc2bd4cb5598f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,7 +22,7 @@ jobs: node-version: ${{ matrix.node-version }} - name: Run sudo tests on Linux - if: matrix.os === "ubuntu-latest" + if: matrix.os == 'ubuntu-latest' run: sudo PATH=$PATH $(which node) . run tap -- "test/tap/*.js" --coverage --timeout 600 # Run the installer script From e02974907fd7f4840a70b0a039354765edacedf5 Mon Sep 17 00:00:00 2001 From: Jason Etcovitch Date: Tue, 29 Oct 2019 13:48:45 -0400 Subject: [PATCH 5/7] Remove sudo tests for now --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fc2bd4cb5598f..434e42b3ceaef 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,9 +21,9 @@ jobs: with: node-version: ${{ matrix.node-version }} - - name: Run sudo tests on Linux - if: matrix.os == 'ubuntu-latest' - run: sudo PATH=$PATH $(which node) . run tap -- "test/tap/*.js" --coverage --timeout 600 + # - name: Run sudo tests on Linux + # if: matrix.os == 'ubuntu-latest' + # run: sudo PATH=$PATH $(which node) . run tap -- "test/tap/*.js" --coverage --timeout 600 # Run the installer script - name: Install dependencies From 93404df575228ad46562742f5437aa446b90f04e Mon Sep 17 00:00:00 2001 From: Jason Etcovitch Date: Tue, 29 Oct 2019 13:50:01 -0400 Subject: [PATCH 6/7] Move sudo tests after dep installation --- .github/workflows/ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 434e42b3ceaef..92219c0f8dc06 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,10 +21,6 @@ jobs: with: node-version: ${{ matrix.node-version }} - # - name: Run sudo tests on Linux - # if: matrix.os == 'ubuntu-latest' - # run: sudo PATH=$PATH $(which node) . run tap -- "test/tap/*.js" --coverage --timeout 600 - # Run the installer script - name: Install dependencies run: node . install @@ -36,6 +32,10 @@ jobs: DEPLOY_VERSION: testing COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_OPTIONAL_TOKEN }} + - name: Run sudo tests on Linux + if: matrix.os == 'ubuntu-latest' + run: sudo PATH=$PATH $(which node) . run tap -- "test/tap/*.js" --coverage --timeout 600 + - name: Lint run: npx standard From 949e4f905dcdea21d136052b73f8894bf512e0df Mon Sep 17 00:00:00 2001 From: Jason Etcovitch Date: Tue, 29 Oct 2019 14:13:36 -0400 Subject: [PATCH 7/7] Boo sudo tests are hanging --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 92219c0f8dc06..7c2c475e0b6a7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -32,9 +32,9 @@ jobs: DEPLOY_VERSION: testing COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_OPTIONAL_TOKEN }} - - name: Run sudo tests on Linux - if: matrix.os == 'ubuntu-latest' - run: sudo PATH=$PATH $(which node) . run tap -- "test/tap/*.js" --coverage --timeout 600 + # - name: Run sudo tests on Linux + # if: matrix.os == 'ubuntu-latest' + # run: sudo PATH=$PATH $(which node) . run tap -- "test/tap/*.js" --coverage --timeout 600 - name: Lint run: npx standard