Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CDN download doesn't use provided HTTP Authorization token (even if it's provided hardcoded in the URL) #331

Open
1 task done
baybal opened this issue Oct 20, 2023 · 0 comments
Labels
Bug thing that needs fixing Needs Triage needs an initial review

Comments

@baybal
Copy link

baybal commented Oct 20, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Authorization token is not passed to downloader, nor from the credential storage, nor from URL directly

$ npm i -S git+https://oauth2:ghp_************@github.com/************/private_repo.git

npm http fetch GET 404 https://codeload.github.com/me/private_repo/tar.gz/hash 1294ms (cache skip)

Expected Behavior

Auth passed to downloader from credential storage

npm http fetch GET 200 https://codeload.github.com/me/private_repo/tar.gz/hash 1294ms (cache skip)

Steps To Reproduce

  1. Create a private repo on GitHub
  2. Create read only GitHub token
  3. $ npm i -S git+https://oauth2:ghp_************@github.com/************/************.git
  4. See it missing cache, and reverting to git+ssh

Environment

  • npm:9.8.1
  • Node:v20.6.1
  • OS:Linux
  • platform:Dell XPS 13
@baybal baybal added Bug thing that needs fixing Needs Triage needs an initial review labels Oct 20, 2023
@baybal baybal changed the title [BUG] CDN download doesn't use provided HTTP Authorization token even if it's provided in the URL [BUG] CDN download doesn't use provided HTTP Authorization token (even if it's provided hardcoded in the URL) Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Needs Triage needs an initial review
Projects
None yet
Development

No branches or pull requests

1 participant