Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bulk writes #5

Open
Al2Klimov opened this issue Aug 8, 2021 · 1 comment
Open

Allow bulk writes #5

Al2Klimov opened this issue Aug 8, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@Al2Klimov
Copy link

... to combine several modifications in one request (which seem to be rate-limited btw., at least this lib rate-limits them).

I.e.: https://desec.readthedocs.io/en/latest/dns/rrsets.html#modifying-an-rrset

@ldez ldez added the enhancement New feature or request label Aug 8, 2021
@adamhassel
Copy link

Would that not simply be changing a function signature or two?

Like

func (s *RecordsService) Update(ctx context.Context, domainName, subName, recordType string, rrSet RRSet) (*RRSet, error)

becomes

func (s *RecordsService) Update(ctx context.Context, domainName, subName, recordType string, rrSet ...RRSet) ([]RRSet, error)

and then you update the test and the docs, and Bob's your uncle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants