Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More detailed layers/filters #16

Open
borazslo opened this issue Jan 16, 2016 · 2 comments
Open

More detailed layers/filters #16

borazslo opened this issue Jan 16, 2016 · 2 comments

Comments

@borazslo
Copy link
Contributor

I suggest to separate the changes layer to a changes and a created layer.

I also suggest to draw a distinction between the two types of deleted. For deleted elements the <action> object has a <new> object. In that the <node> osm element has a visible marker. If the element is deleted from the osm database then visible="false". If the element is not delete, but the element does not match the adiff query at the second time then visible="true". (See more: Augmented_Diffs) I think it is important to know whether an osm element is absolutely deleted or only does not match my filter criterions. (This issue is probably related with the usage of?url=my_own_adiff_xml_results only.)

@nrenner
Copy link
Owner

nrenner commented Jan 18, 2016

Hm, the old and changes layers correspond to the old and new (before/after) in the diff and I guess I would like to keep especially the changes layer in the current way to be able to turn off all after objects with a single click to see the before state.

But I agree that additional filters (deleted/modified/created, ...) would be helpful, either as a nested tree checkboxes or as separate filters. But those would probably need to be implemented in a different way than to simply removing and adding layers.

Need to check the deleted types handling - I am aware of the issue, I guess Roland called these "out of scope". I guess only a warning in the popup is shown for such edge cases, but yes, special styling and probably filters would be helpful.

@nrenner
Copy link
Owner

nrenner commented Jan 22, 2016

Handling of out of scope objects is still an open task, but delete + visible="true" is already taken into account. It is assumed that the geometry was moved outside the requested bbox/area and therefore it is styled as old geometry (see legend) and a warning is shown in the popup.

I guess more information would be needed to detect and distinguish all cases (like retagged vs. moved outside bbox).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants