From 6d62835de6c3830437764bcb61dcfde924f419ec Mon Sep 17 00:00:00 2001 From: Nicholas Ruffing Date: Sun, 28 Jan 2024 10:33:12 -0500 Subject: [PATCH] Revert "feat(theme-default): remove ari-hidden on title and use an empty alt on brand image if not specified" This reverts commit 425090354edce05bdcda72161dda922f90625ff0. --- .../src/client/components/NavbarBrand.vue | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/themes/theme-default/src/client/components/NavbarBrand.vue b/themes/theme-default/src/client/components/NavbarBrand.vue index 5a1a3e3c1a..9928e72a84 100644 --- a/themes/theme-default/src/client/components/NavbarBrand.vue +++ b/themes/theme-default/src/client/components/NavbarBrand.vue @@ -24,7 +24,14 @@ const navbarBrandLogo = computed(() => { } return themeLocale.value.logo }) -const navbarBrandLogoAlt = computed(() => themeLocale.value.logoAlt ?? '') +const navbarBrandLogoAlt = computed( + () => themeLocale.value.logoAlt ?? navbarBrandTitle.value, +) +const navBarLogoAltMatchesTitle = computed( + () => + navbarBrandTitle.value.toLocaleUpperCase().trim() === + navbarBrandLogoAlt.value.toLocaleUpperCase().trim(), +) const NavbarBrandLogo: FunctionalComponent = () => { if (!navbarBrandLogo.value) return null const img = h('img', { @@ -49,6 +56,7 @@ const NavbarBrandLogo: FunctionalComponent = () => { v-if="navbarBrandTitle" class="site-name" :class="{ 'can-hide': navbarBrandLogo }" + :aria-hidden="navBarLogoAltMatchesTitle" > {{ navbarBrandTitle }}