feat: allow filtering in the nx project tree view #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit eab4d76. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
Cammisuli
force-pushed
the
nx-project-tree-filter
branch
from
bda149d
to
399a31f
Compare
Cammisuli
force-pushed
the
nx-project-tree-filter
branch
from
399a31f
to
eab4d76
Compare
Cammisuli
commented
Mar 26, 2021
Comment on lines
-69
to
-75
| "command": "nxConsole.revealInExplorer", | ||
| "when": "view == nxConsoleJson && viewItem == project", | ||
| "group": "inline" | ||
| }, | ||
| { | ||
| "command": "nxConsole.runTask", | ||
| "when": "view == nxConsoleJson && viewItem == task", |
There was a problem hiding this comment.
The nxConsoleJson view doesn't exist. So I just removed this.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This change introduces a new button in the nx projects tree view that replaces the single click to open the workspace.json file. This allows us to focus the view and start typing so that we can use the built in filter in vscode.
Screenshots:
New button to open workspace.json
Filter
Closes #1043
Note
This is based off the current refactor branch, and will need to be rebased.