Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use proper file paths for schemas within windows #1085

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

Cammisuli
Copy link
Member

@Cammisuli Cammisuli commented Jun 16, 2021

What it does

Fixes the absolute path for the schema files for the workspace json schema. Windows should now have the proper absolute file
path notation file:///c:/.../schema.json

Windows

image

macOS

image

Fixes #1083

@nx-cloud
Copy link

nx-cloud bot commented Jun 16, 2021

Nx Cloud Report

CI ran the following commands for commit 9f7723c. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --all --parallel --target=build
#000000 nx run-many --all --parallel --target=lint
#000000 nx run-many --all --parallel --target=test

Sent with 💌 from NxCloud.

@Cammisuli Cammisuli changed the title fix: change backslashes to forward slashes in the json schema fix: use proper file paths for schemas within windows Jun 16, 2021
@Cammisuli Cammisuli merged commit ed9d0c7 into nrwl:master Jun 16, 2021
@Cammisuli Cammisuli deleted the json-schema-fix-for-windows branch June 16, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspace JSON Schema does not work on windows
1 participant