-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sort projects in project view #1137
Conversation
Nx Cloud ReportCI ran the following commands for commit 73718cf. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
wait, I'm surprised it's not reflected in panel view. I'll mark this as WIP. Any clue where to look? thx! |
If you want to sort the projects in the Projects view, then you'll have to manipulate the nx-console/libs/vscode/nx-project-view/src/lib/nx-project-tree-provider.ts Lines 88 to 96 in 7ad5f60
|
@Cammisuli thx! Let me check this. |
This was probably due to staled branch bits or something. I can see it works as expected. Projects are sorted, @Cammisuli can you please clone this and run, just to confirm. |
oh ya, the original implementation was working 😅 Once you're ready, we can merge this in and release it |
This commit adds sorting applied to projects found in workspace configuration, before content is returned to the UI. Entries are sorted using current environment locale settings. This commit contains also changes required to start tests in context of VSCode environment. - implementation - tests Thanks! Closes nrwl#1111
1b22331
to
73718cf
Compare
Done, I've hardened the tests mocks for file system checks, they were returning kind of random outcome, now that's correctted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! It's going to be coming out in the next release very soon 😄
This commit adds sorting applied to projects found in workspace
configuration, before content is returned to the UI. Entries are sorted
using current environment locale settings.
Thanks!
Closes #1111