feat: use nx utils to read all configuration files #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit c08f1e6. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
AgentEnder
reviewed
Dec 3, 2021
apps/vscode/src/main.ts
Outdated
| @@ -116,6 +117,7 @@ export async function activate(c: ExtensionContext) { | |||
| const vscodeWorkspacePath = | |||
| workspace.workspaceFolders && workspace.workspaceFolders[0].uri.fsPath; | |||
|
|
|||
| debugger; | |||
| @@ -352,7 +355,9 @@ function renameProperty(obj: any, from: string, to: string) { | |||
| delete obj[from]; | |||
| } | |||
|
|
|||
| export function toWorkspaceFormat(w: any): WorkspaceJsonConfiguration { | |||
| export function toWorkspaceFormat( | |||
There was a problem hiding this comment.
This function could reuse toNewFormat from @nrwl/tao
There was a problem hiding this comment.
These linked lines are probably not needed anymore since we use the NX helpers to read config
|
Need to finish #1057 before this can complete. The latest versions of angular cli is not as backwards compatible as nx, so we need to completely remove our dependency on ng cli |
Cammisuli
force-pushed
the
use-nx-utils-for-configs
branch
from
b817e76
to
13d5687
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR removes all direct reads to the workspace/project/angular/nx.json files and uses the utils provided by Nx. This allows Nx Console to always know what configurations are available without having to worry about workspace changes.