Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client http server for token #80

Closed
wants to merge 10 commits into from
Closed

Client http server for token #80

wants to merge 10 commits into from

Commits on Sep 9, 2018

  1. Fix the gitlab oauth issue. 

    Now the problem is tha API is wrong.  Sigh...
    @lyda
    lyda committed Sep 9, 2018
    Configuration menu
    Copy the full SHA
    23e363c View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2018

  1. Update for gitlab 11.1+ 

    Versions beyond 11.1 (and possibly a few releases before) use a
different method for delivering tokens.  They also have disabled
version 3 of the api.

These changes address that and add a debugging mode for the server
that make it easier to debug issues like this in the future.
    @lyda
    lyda committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    8a9cd6c View commit details
    Browse the repository at this point in the history

  2. Add auto_token client option 

    Add an auto_token client option to change the flow such that the
token will be sent back to the client directly by the browser.
There are a number of "TODO" messages in this commit which will
hopefully be addressed in code review. I'm not sure if they're
needed.
    @lyda
    lyda committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    c1e0051 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2018

  1. Much simpler version thanks to Niall's feedback.

    @lyda
    lyda committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    f5661c0 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2018

  1. Only pass around the port for auto tokens.

    @lyda
    lyda committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    dcc97ce View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into client-http-server-for-token

    @lyda
    lyda committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    ccb291d View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2018

  1. Work when auto_token is false.

    @lyda
    lyda committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    915de78 View commit details
    Browse the repository at this point in the history

  2. Always send auto_token.

    @lyda
    lyda committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    3fda221 View commit details
    Browse the repository at this point in the history

  3. Handle reauths.

    @lyda
    lyda committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    c18821f View commit details
    Browse the repository at this point in the history

  4. Revert "Always send auto_token." 

    This reverts commit 3fda221.
    @lyda
    lyda committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    2728a4d View commit details
    Browse the repository at this point in the history