Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider dependency groups #619

Closed
Tracked by #614
mfisher87 opened this issue Jun 26, 2024 · 0 comments · Fixed by #733
Closed
Tracked by #614

Reconsider dependency groups #619

mfisher87 opened this issue Jun 26, 2024 · 0 comments · Fixed by #733
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mfisher87
Copy link
Collaborator

mfisher87 commented Jun 26, 2024

Right now we only have a dev group. In that group, many things are listed, ranging from testing to docs to linting. IMO, we should have a dev group which includes only dev tools like pre-commit and Nox which are capable of managing their own environments. Then we can have two more groups: docs for mkdocs and friends. test for pytest, mypy, and friends. We can then use nox to handle running tasks like building docs, typechecking, and testing. Pre-commit handles everything that doesn't require the project's dependencies, like linting and formatting and various miscellaneous safety checks.

Regardless of whether we use Nox, I think it will be valuable to break out these 3 groups. More discussion here! #614

@mfisher87 mfisher87 changed the title Dependency groups: right now we only have a dev group. In that group, many things are listed, ranging from testing to docs to linting. IMO, we should have a dev group which includes only dev tools like pre-commit and Nox which are capable of managing their own environments. Have two more groups: docs for mkdocs and friends. test for pytest, mypy, and friends. Use nox to handle running tasks like building docs, typechecking, and testing. Pre-commit handles everything that doesn't require the project's dependencies, like linting and formatting and various miscellaneous safety checks. Reconsider dependency groups Jun 26, 2024
@mfisher87 mfisher87 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers and removed good first issue Good for newcomers labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Done
1 participant