-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework network configuration parameters #372
Comments
Same goes for |
Add some sane limits to numerics (like object size) as well to avoid code like in nspcc-dev/neofs-node#2674 (comment). |
what do you guys think about adding notifications about changing values? They'd help sys nodes react more quickly to reconfigs. Although this is a separate topic, with new interface proposed within this one the notifications would be implemented more clear and less abstract (per-config notifications) |
Yep, makes sense. |
Triggers too many changes to be done now. API operates with |
Is your feature request related to a problem? Please describe.
I'm always frustrated when I'm looking at SetConfig/Config pair of the netmap contract. Only node knows what can be changed, only node knows what are the defaults, only node knows how to properly encode them and we have all settings in a single contract even though they're often unrelated.
Describe the solution you'd like
Move configuration options into contracts and make proper interfaces for them. No abstract options, please, everything must have a proper documented interface with the default value. Economic options are not a part of
netmap
, container options are not a part ofnetmap
, reputation options are not a part ofnetmap
.Describe alternatives you've considered
Leaving opaque container, passing magic values on deploy. No, thanks.
The text was updated successfully, but these errors were encountered: