Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove symlink after prepare storage target #109

Open
alexvanin opened this issue Jul 6, 2021 · 1 comment
Open

Remove symlink after prepare storage target #109

alexvanin opened this issue Jul 6, 2021 · 1 comment
Labels
bug Something isn't working I3 Minimal impact S4 Routine U4 Nothing urgent

Comments

@alexvanin
Copy link
Contributor

After #92 we have prepare.storage target that creates storage node's TLS certificate symlink to the host machine. However it never removed. make clean target removes storage node's certificate but it didn't affect symlink. It solves the issue technically, but it would be better if we will keep clean host machine.

Possible options:

  • do not create symlink at prepare.storage target, but show ln -s command for the user to manage it on it's own (kinda like we propose to modify /etc/hosts file and do not modify it in the scripts,
  • remove symlink at make clean target.
@fyrchik
Copy link
Contributor

fyrchik commented Aug 23, 2022

This may be related:

> make down clean >/dev/null 2>&1 && make up >/dev/null 2>&1 && ls -lh services/storage/s04tls*
-rw-r--r-- 1 dzeta dzeta 2,0K авг 23 16:31 services/storage/s04tls.crt
-rw------- 1 dzeta dzeta 3,2K авг 23 16:31 services/storage/s04tls.key

> make down clean up >/dev/null 2>&1 && ls -lh services/storage/s04tls*
services/storage/s04tls.crt:
итого 0

services/storage/s04tls.key:
итого 0
dzeta@wpc ~/r/neofs-dev-env (real-clean)>

@roman-khimov roman-khimov added bug Something isn't working U4 Nothing urgent S4 Routine I3 Minimal impact and removed enhancement Improving existing functionality labels Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working I3 Minimal impact S4 Routine U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

3 participants