Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet/wallet.json is useless #266

Open
notimetoname opened this issue Jun 19, 2023 · 3 comments
Open

wallet/wallet.json is useless #266

notimetoname opened this issue Jun 19, 2023 · 3 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation I3 Minimal impact S3 Minimally significant U3 Regular

Comments

@notimetoname
Copy link
Contributor

notimetoname commented Jun 19, 2023

With 61fd192 that wallet becomes as useful as any other just-generated wallet. None of make commands deposits on it, no container can be created with it, etc. But on the other hand it is still mentioned in README (and in doc dir too).
I would add a separate make target that replenishes wallet/wallet.json and add it as a prerequisite for any up command. @roman-khimov

@notimetoname notimetoname added bug Something isn't working documentation Improvements or additions to documentation discussion Open discussion of some problem labels Jun 19, 2023
@roman-khimov
Copy link
Member

IIUC documentation mentions that a GAS transfer should be made, if you can make it easier to use -- OK.

@notimetoname
Copy link
Contributor Author

IIUC documentation mentions that a GAS transfer should be made

@roman-khimov, updated the link(s). I read it as "do make prepare.ir and wallet/wallet.json is your door to the NeoFS". And that is how I used to use it.
Now it is just an empty wallet. Making a transfer to it means a user knows what neo-go is and how to use it. So I think we should either drop it or make it great (useful) again.
BTW, why neo-go needs a neofs balance? I think smth is wrong here.

@cthulhu-rider
Copy link
Contributor

being a DevEnv user, i'd appreciate having both fixed "zero" wallet and the "one with some deposit sufficient for ~80% needs" from the box, e.g.:

  • wallets/wallet.json with deposit
  • wallets/wallet_other.json empty
    or vice-versa wallets/wallet.json and wallets/wallet_funded.json

@roman-khimov roman-khimov added U3 Regular S3 Minimally significant I3 Minimal impact and removed discussion Open discussion of some problem labels Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation I3 Minimal impact S3 Minimally significant U3 Regular
Projects
None yet
Development

No branches or pull requests

3 participants