Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests to not use --exit flag for more graceful termination #10

Closed
ntgomes opened this issue Nov 6, 2022 · 1 comment
Closed

Fix tests to not use --exit flag for more graceful termination #10

ntgomes opened this issue Nov 6, 2022 · 1 comment
Assignees
Labels
testing Something related to tests
Milestone

Comments

@ntgomes
Copy link
Owner

ntgomes commented Nov 6, 2022

According to https://stackoverflow.com/a/46759250, using the --exit flag for mocha is not advised since it's only hiding the true issue of unclosed connections that chai-mocha is waiting for after all tests pass. Find what unclosed connection there is that's blocking mocha from terminating without the --exit flag, and make changes to close that connection properly.

@ntgomes ntgomes added bug Something isn't working testing Something related to tests and removed bug Something isn't working labels Nov 6, 2022
@ntgomes ntgomes self-assigned this Nov 17, 2022
@ntgomes
Copy link
Owner Author

ntgomes commented Nov 18, 2022

Update: according to chai-http developers, having --exit is fine due to change in default behavior. chaijs/chai-http#178 (comment)

So the guy from the StackOverflow answer probably didn't understand what they were talking about.

@ntgomes ntgomes closed this as completed Nov 18, 2022
@ntgomes ntgomes added this to the Week 2 Sprint milestone Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Something related to tests
Projects
None yet
Development

No branches or pull requests

1 participant