Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging SMBv1 and SMBv23? #2246

Open
IvanNardi opened this issue Jan 8, 2024 · 1 comment
Open

Merging SMBv1 and SMBv23? #2246

IvanNardi opened this issue Jan 8, 2024 · 1 comment
Labels
question

Comments

@IvanNardi
Copy link
Collaborator

Should we have only one protocol id for SMB1 and SMBv2, both?
See: #2245 (comment)
@0xA50C1A1
Copy link
Contributor

0xA50C1A1 commented Jan 8, 2024 •
edited
Loading

Well, that sounds logical. This seems to be the way SSH detection is implemented. I.e. one ID for all protocol versions and risk setting in case an obsolete version is detected.

@0xA50C1A1 0xA50C1A1 mentioned this issue Jan 9, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IvanNardi @0xA50C1A1